[Datasets] Remove the assertion for ds.stats() in test_dataset_image.py #33171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Su <[email protected]>
c21
requested review from
ericl,
scv119,
clarkzinzow,
jjyao and
jianoaix
as code owners
Signed-off-by: Cheng Su <[email protected]>
jianoaix
approved these changes
Mar 9, 2023
c21
added
the
tests-ok
clarkzinzow
approved these changes
Mar 9, 2023
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
…py (ray-project#33171) The test is very flaky and it's because the async nature from StatsActor for ds.stats() call (some discssuion in the past). We can remove the assertion here because the assertion of ds.num_blocks() is enough, and we have separate test file stats - test_stats.py. Signed-off-by: Cheng Su <[email protected]> Signed-off-by: Jack He <[email protected]>
cadedaniel
pushed a commit
to cadedaniel/ray
that referenced
this pull request
Mar 22, 2023
…py (ray-project#33171) The test is very flaky and it's because the async nature from StatsActor for ds.stats() call (some discssuion in the past). We can remove the assertion here because the assertion of ds.num_blocks() is enough, and we have separate test file stats - test_stats.py. Signed-off-by: Cheng Su <[email protected]>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…py (ray-project#33171) The test is very flaky and it's because the async nature from StatsActor for ds.stats() call (some discssuion in the past). We can remove the assertion here because the assertion of ds.num_blocks() is enough, and we have separate test file stats - test_stats.py. Signed-off-by: Cheng Su <[email protected]> Signed-off-by: Edward Oakes <[email protected]>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
…py (ray-project#33171) The test is very flaky and it's because the async nature from StatsActor for ds.stats() call (some discssuion in the past). We can remove the assertion here because the assertion of ds.num_blocks() is enough, and we have separate test file stats - test_stats.py. Signed-off-by: Cheng Su <[email protected]>
scottsun94
pushed a commit
to scottsun94/ray
that referenced
this pull request
Mar 28, 2023
…py (ray-project#33171) The test is very flaky and it's because the async nature from StatsActor for ds.stats() call (some discssuion in the past). We can remove the assertion here because the assertion of ds.num_blocks() is enough, and we have separate test file stats - test_stats.py. Signed-off-by: Cheng Su <[email protected]>
cassidylaidlaw
pushed a commit
to cassidylaidlaw/ray
that referenced
this pull request
Mar 28, 2023
…py (ray-project#33171) The test is very flaky and it's because the async nature from StatsActor for ds.stats() call (some discssuion in the past). We can remove the assertion here because the assertion of ds.num_blocks() is enough, and we have separate test file stats - test_stats.py. Signed-off-by: Cheng Su <[email protected]>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…py (ray-project#33171) The test is very flaky and it's because the async nature from StatsActor for ds.stats() call (some discssuion in the past). We can remove the assertion here because the assertion of ds.num_blocks() is enough, and we have separate test file stats - test_stats.py. Signed-off-by: Cheng Su <[email protected]> Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…py (ray-project#33171) The test is very flaky and it's because the async nature from StatsActor for ds.stats() call (some discssuion in the past). We can remove the assertion here because the assertion of ds.num_blocks() is enough, and we have separate test file stats - test_stats.py. Signed-off-by: Cheng Su <[email protected]> Signed-off-by: Jack He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The test is very flaky and it's because the async nature from StatsActor for ds.stats() call (some discssuion in the past). We can remove the assertion here because the assertion of
ds.num_blocks()is enough, and we have separate test file stats -test_stats.py.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.