[Doc] Add workaround to Serve docs for broken dependency #33136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaihsun <[email protected]>
Signed-off-by: Archit Kulkarni <[email protected]>
architkulkarni
requested review from
simon-mo,
jiaodong,
shrekris-anyscale,
sihanwang41 and
a team
as code owners
edoakes
approved these changes
Mar 8, 2023
doc/source/serve/tutorials/batch.md
Outdated
| ``` | ||
|
|
||
| You can downgrade the protobuf package to 3.20.x or lower by using a [runtime environment](runtime-environments). |
There was a problem hiding this comment.
mention that they can also do this in their docker image
There was a problem hiding this comment.
Makes sense, added
kevin85421
approved these changes
Mar 8, 2023
Signed-off-by: Archit Kulkarni <[email protected]>
sihanwang41
approved these changes
Mar 8, 2023
|
Linkcheck failure |
architkulkarni
added
the
tests-ok
architkulkarni
added a commit
to architkulkarni/ray
that referenced
this pull request
Mar 8, 2023
…-project#33136) The protobuf version in the latest Ray ML images is causing issues when importing certain libraries. This is the second sub-issue of ray-project#32775. This PR adds a runtime_env-based workaround to the Serve examples to unblock users if they run into this issue. We will cherry pick this into the 2.3.1 branch and revert this PR on master once the underlying issue in the images is fixed on master. This PR is based on ray-project#33024, thanks @kevin85421 for reporting and opening the PR!
7 tasks
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
Mar 21, 2023
…-project#33136) The protobuf version in the latest Ray ML images is causing issues when importing certain libraries. This is the second sub-issue of ray-project#32775. This PR adds a runtime_env-based workaround to the Serve examples to unblock users if they run into this issue. We will cherry pick this into the 2.3.1 branch and revert this PR on master once the underlying issue in the images is fixed on master. This PR is based on ray-project#33024, thanks @kevin85421 for reporting and opening the PR! Signed-off-by: Jack He <[email protected]>
cadedaniel
pushed a commit
to cadedaniel/ray
that referenced
this pull request
Mar 22, 2023
…-project#33136) The protobuf version in the latest Ray ML images is causing issues when importing certain libraries. This is the second sub-issue of ray-project#32775. This PR adds a runtime_env-based workaround to the Serve examples to unblock users if they run into this issue. We will cherry pick this into the 2.3.1 branch and revert this PR on master once the underlying issue in the images is fixed on master. This PR is based on ray-project#33024, thanks @kevin85421 for reporting and opening the PR!
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…-project#33136) The protobuf version in the latest Ray ML images is causing issues when importing certain libraries. This is the second sub-issue of ray-project#32775. This PR adds a runtime_env-based workaround to the Serve examples to unblock users if they run into this issue. We will cherry pick this into the 2.3.1 branch and revert this PR on master once the underlying issue in the images is fixed on master. This PR is based on ray-project#33024, thanks @kevin85421 for reporting and opening the PR! Signed-off-by: Edward Oakes <[email protected]>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
…-project#33136) The protobuf version in the latest Ray ML images is causing issues when importing certain libraries. This is the second sub-issue of ray-project#32775. This PR adds a runtime_env-based workaround to the Serve examples to unblock users if they run into this issue. We will cherry pick this into the 2.3.1 branch and revert this PR on master once the underlying issue in the images is fixed on master. This PR is based on ray-project#33024, thanks @kevin85421 for reporting and opening the PR!
zcin
pushed a commit
that referenced
this pull request
Mar 27, 2023
) (#33146) The protobuf version in the latest Ray ML images is causing issues when importing certain libraries. This is the second sub-issue of #32775. This PR adds a runtime_env-based workaround to the Serve examples to unblock users if they run into this issue. We will cherry pick this into the 2.3.1 branch and revert this PR on master once the underlying issue in the images is fixed on master. This PR is based on #33024, thanks @kevin85421 for reporting and opening the PR!
scottsun94
pushed a commit
to scottsun94/ray
that referenced
this pull request
Mar 28, 2023
…-project#33136) The protobuf version in the latest Ray ML images is causing issues when importing certain libraries. This is the second sub-issue of ray-project#32775. This PR adds a runtime_env-based workaround to the Serve examples to unblock users if they run into this issue. We will cherry pick this into the 2.3.1 branch and revert this PR on master once the underlying issue in the images is fixed on master. This PR is based on ray-project#33024, thanks @kevin85421 for reporting and opening the PR!
cassidylaidlaw
pushed a commit
to cassidylaidlaw/ray
that referenced
this pull request
Mar 28, 2023
…-project#33136) The protobuf version in the latest Ray ML images is causing issues when importing certain libraries. This is the second sub-issue of ray-project#32775. This PR adds a runtime_env-based workaround to the Serve examples to unblock users if they run into this issue. We will cherry pick this into the 2.3.1 branch and revert this PR on master once the underlying issue in the images is fixed on master. This PR is based on ray-project#33024, thanks @kevin85421 for reporting and opening the PR!
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…-project#33136) The protobuf version in the latest Ray ML images is causing issues when importing certain libraries. This is the second sub-issue of ray-project#32775. This PR adds a runtime_env-based workaround to the Serve examples to unblock users if they run into this issue. We will cherry pick this into the 2.3.1 branch and revert this PR on master once the underlying issue in the images is fixed on master. This PR is based on ray-project#33024, thanks @kevin85421 for reporting and opening the PR! Signed-off-by: elliottower <[email protected]>
ProjectsByJackHe
pushed a commit
to ProjectsByJackHe/ray
that referenced
this pull request
May 4, 2023
…-project#33136) The protobuf version in the latest Ray ML images is causing issues when importing certain libraries. This is the second sub-issue of ray-project#32775. This PR adds a runtime_env-based workaround to the Serve examples to unblock users if they run into this issue. We will cherry pick this into the 2.3.1 branch and revert this PR on master once the underlying issue in the images is fixed on master. This PR is based on ray-project#33024, thanks @kevin85421 for reporting and opening the PR! Signed-off-by: Jack He <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The
protobufversion in the latest Ray ML images is causing issues when importing certain libraries. This is the second sub-issue of #32775.This PR adds a
runtime_env-based workaround to the Serve examples to unblock users if they run into this issue. We will cherry pick this into the 2.3.1 branch and revert this PR on master once the underlying issue in the images is fixed on master.This PR is based on #33024, thanks @kevin85421 for reporting and opening the PR!
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.