Fix or re-revert https://github.com/ray-project/ray/pull/32690 #32807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitri Gekhtman <[email protected]>
fishbone
approved these changes
Feb 24, 2023
|
Looks like this fixed this issue -- will wait for CI to run to completion and merge in the morning if all looks good. |
rkooo567
approved these changes
Feb 24, 2023
cadedaniel
pushed a commit
to cadedaniel/ray
that referenced
this pull request
Mar 22, 2023
The newly introduced test from ray-project#32690 fails on Windows, so skip it. The likely cause is an incompatibility of the test logic with Windows. In any case, it's not important to support functionality added in that PR on Windows.
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
The newly introduced test from ray-project#32690 fails on Windows, so skip it. The likely cause is an incompatibility of the test logic with Windows. In any case, it's not important to support functionality added in that PR on Windows. Signed-off-by: Edward Oakes <[email protected]>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
The newly introduced test from ray-project#32690 fails on Windows, so skip it. The likely cause is an incompatibility of the test logic with Windows. In any case, it's not important to support functionality added in that PR on Windows.
scottsun94
pushed a commit
to scottsun94/ray
that referenced
this pull request
Mar 28, 2023
The newly introduced test from ray-project#32690 fails on Windows, so skip it. The likely cause is an incompatibility of the test logic with Windows. In any case, it's not important to support functionality added in that PR on Windows.
cassidylaidlaw
pushed a commit
to cassidylaidlaw/ray
that referenced
this pull request
Mar 28, 2023
The newly introduced test from ray-project#32690 fails on Windows, so skip it. The likely cause is an incompatibility of the test logic with Windows. In any case, it's not important to support functionality added in that PR on Windows.
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
The newly introduced test from ray-project#32690 fails on Windows, so skip it. The likely cause is an incompatibility of the test logic with Windows. In any case, it's not important to support functionality added in that PR on Windows. Signed-off-by: elliottower <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The newly introduced test from #32690 fails on Windows, so skip it.
The likely cause is an incompatibility of the test logic with Windows. In any case, it's not important to support functionality added in that PR on Windows.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.