Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Exclude gpu tag from Examples test suite in RLlib #32141

Merged

Conversation

kouroshHakha
Copy link
Contributor

@kouroshHakha kouroshHakha commented Jan 31, 2023

RLlib's tests that are tagged examples but not tagged gpu or multi-gpu, should run on no-gpu instances, so we should exclude the gpu tag (similar to how multi-gpu is already excluded)

Signed-off-by: Kourosh Hakhamaneshi [email protected]

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…ld exclude the gpu tag

Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@kouroshHakha kouroshHakha mentioned this pull request Jan 31, 2023
7 tasks
@kouroshHakha
Copy link
Contributor Author

ok, everything works still:
image

Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@gjoliver gjoliver merged commit b81f0cd into ray-project:master Feb 2, 2023
cadedaniel pushed a commit to cadedaniel/ray that referenced this pull request Mar 22, 2023
…t#32141)

* RLlib's example test suite should run on no-gpu instances, so we should exclude the gpu tag

Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…t#32141)

* RLlib's example test suite should run on no-gpu instances, so we should exclude the gpu tag

Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
Signed-off-by: Edward Oakes <[email protected]>
scottsun94 pushed a commit to scottsun94/ray that referenced this pull request Mar 28, 2023
…t#32141)

* RLlib's example test suite should run on no-gpu instances, so we should exclude the gpu tag

Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
cassidylaidlaw pushed a commit to cassidylaidlaw/ray that referenced this pull request Mar 28, 2023
…t#32141)

* RLlib's example test suite should run on no-gpu instances, so we should exclude the gpu tag

Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants