[Dashboard] Add job_id to task API calls + Show resource requirement for pg #32104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SangBin Cho <[email protected]>
alanwguo
reviewed
Jan 31, 2023
Comment on lines
+25
to
+30
| {bundles.map(({ unit_resources }, index) => { | ||
| return `{${Object.entries(unit_resources || {}) | ||
| .map(([key, val]) => `${key}: ${val}`) | ||
| .join(", ")}}, `; | ||
| })} | ||
| </div> |
There was a problem hiding this comment.
Group by bundle definition.
Comment on lines
+5
to
+13
| export const getTasks = (jobId: string | null) => { | ||
| let url = "api/v0/tasks?detail=1&limit=10000"; | ||
| if (jobId) { | ||
| url += `&job_id=${jobId}`; | ||
| } | ||
| return get<StateApiResponse<Task>>(url); | ||
| }; | ||
|
|
||
| export const downloadTaskTimelineHref = (jobId: string) => { | ||
| return `/api/v0/tasks/timeline?job_id=${jobId}&download=1`; | ||
| export const downloadTaskTimelineHref = (jobId: string | null) => { |
There was a problem hiding this comment.
it could be useful for things like serve in the future. I just did it because it is a simple change. Doesn't have to be included in this PR if you don't want to
alanwguo
approved these changes
Jan 31, 2023
cadedaniel
pushed a commit
to cadedaniel/ray
that referenced
this pull request
Mar 22, 2023
Signed-off-by: SangBin Cho <[email protected]> Add job id to the task state API call. This will help us not including tasks from other jobs (so improve the experience when we have 10K+ tasks from the cluster). Add resource requirement to the pg table.
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Signed-off-by: SangBin Cho <[email protected]> Add job id to the task state API call. This will help us not including tasks from other jobs (so improve the experience when we have 10K+ tasks from the cluster). Add resource requirement to the pg table. Signed-off-by: Edward Oakes <[email protected]>
scottsun94
pushed a commit
to scottsun94/ray
that referenced
this pull request
Mar 28, 2023
Signed-off-by: SangBin Cho <[email protected]> Add job id to the task state API call. This will help us not including tasks from other jobs (so improve the experience when we have 10K+ tasks from the cluster). Add resource requirement to the pg table.
cassidylaidlaw
pushed a commit
to cassidylaidlaw/ray
that referenced
this pull request
Mar 28, 2023
Signed-off-by: SangBin Cho <[email protected]> Add job id to the task state API call. This will help us not including tasks from other jobs (so improve the experience when we have 10K+ tasks from the cluster). Add resource requirement to the pg table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SangBin Cho [email protected]
Why are these changes needed?
idk what I am doing wrong, but the overflow doesn't work somehow. @alanwguo do you know how to handle this? I think we will need this for demo
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.