Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Do not store metrics in DB #31755

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jan 18, 2023

Signed-off-by: Antoni Baum [email protected]

Why are these changes needed?

We stop storing metric jsons in the release test database as they are now uploaded as separate buildkite artifacts and can be obtained using buildkite's API (metric collection is unaffected).

https://buildkite.com/docs/apis/rest-api/artifacts

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke merged commit faa9a2c into ray-project:master Jan 20, 2023
@Yard1 Yard1 deleted the do_not_store_metrics_in_db branch January 20, 2023 01:01
andreapiso pushed a commit to andreapiso/ray that referenced this pull request Jan 22, 2023
We stop storing metric jsons in the release test database as they are now uploaded as separate buildkite artifacts and can be obtained using buildkite's API (metric collection is unaffected).

https://buildkite.com/docs/apis/rest-api/artifacts

Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Andrea Pisoni <[email protected]>
cassidylaidlaw pushed a commit to cassidylaidlaw/ray that referenced this pull request Mar 28, 2023
We stop storing metric jsons in the release test database as they are now uploaded as separate buildkite artifacts and can be obtained using buildkite's API (metric collection is unaffected).

https://buildkite.com/docs/apis/rest-api/artifacts

Signed-off-by: Antoni Baum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants