[RLlib] Introduce Connector Metrics #31618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,10 +21,17 @@ | |||
| class ActionConnectorPipeline(ConnectorPipeline, ActionConnector): | |||
| def __init__(self, ctx: ConnectorContext, connectors: List[Connector]): | |||
| super().__init__(ctx, connectors) | |||
| self.timers = defaultdict(_Timer) | |||
There was a problem hiding this comment.
I thought about putting this in the ConnectorPipeline class but it has no functionality related to timers if I do that and it would make the inheritance model which we have here even weirder.
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
fffe99b
to
8bef040
Compare
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
gjoliver
reviewed
Jan 17, 2023
rllib/connectors/action/pipeline.py
Outdated
| self.timers = defaultdict(_Timer) | ||
|
|
||
| def reset(self, env_id: str): | ||
| self.timers.clear() |
There was a problem hiding this comment.
maybe we don't want to reset timers.
like nobody is resetting action connector right now.
There was a problem hiding this comment.
Changed, thanks!
rllib/evaluation/env_runner_v2.py
Outdated
| # Create connector metrics | ||
| connector_metrics = {} | ||
| for policy_id, policy in self._worker.policy_map.items(): | ||
| connector_metrics[policy_id] = policy.get_connector_throughput_metrics() |
There was a problem hiding this comment.
this could be pretty costly. any chance we can only update the policies that are used for these episodes?
at the very least, let's only update the cached poclies.
There was a problem hiding this comment.
Changed, thanks! 👍
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
|
a lot of test failure. can you take a look / re-trigger? |
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
gjoliver
approved these changes
Jan 18, 2023
andreapiso
pushed a commit
to andreapiso/ray
that referenced
this pull request
Jan 22, 2023
Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: Andrea Pisoni <[email protected]>
cassidylaidlaw
pushed a commit
to cassidylaidlaw/ray
that referenced
this pull request
Mar 28, 2023
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst [email protected]
Why are these changes needed?
In order to properly better understand the influence of connector runtime, this PR introduces a first set of metrics and makes the necessary changes to support easy addition of more metrics related to connectors.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.