Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci/release] Use job-based file manager for SDK runner per default #31493

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Jan 6, 2023

Signed-off-by: Kai Fricke [email protected]

Why are these changes needed?

Release tests are currently failing with an error on file upload (botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This is likely because some tests are using an anyscale push-based API to upload files. By switching to the job-based filemanager for all tests the upload issue should be mitigated.

Please note that execution will still happen with SDK commands for those tests that haven't specified to use jobs for execution, so actual test execution should be unaffected.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rkooo567 rkooo567 merged commit a8d8ceb into ray-project:master Jan 6, 2023
@rkooo567
Copy link
Contributor

rkooo567 commented Jan 6, 2023

Can you monitor if infra failures are increasing?

@krfricke krfricke deleted the ci/release/jobs-file-manager branch January 6, 2023 14:42
@krfricke
Copy link
Contributor Author

krfricke commented Jan 6, 2023

Will do!

AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
…31493)

Signed-off-by: Kai Fricke <[email protected]>

Release tests are currently failing with an error on file upload (botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This is likely because some tests are using an anyscale push-based API to upload files. By switching to the job-based filemanager for all tests the upload issue should be mitigated.

Please note that execution will still happen with SDK commands for those tests that haven't specified to use jobs for execution, so actual test execution should be unaffected.
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 16, 2023
…ay-project#31493)

Signed-off-by: Kai Fricke <[email protected]>

Release tests are currently failing with an error on file upload (botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This is likely because some tests are using an anyscale push-based API to upload files. By switching to the job-based filemanager for all tests the upload issue should be mitigated.

Please note that execution will still happen with SDK commands for those tests that haven't specified to use jobs for execution, so actual test execution should be unaffected.

Signed-off-by: tmynn <[email protected]>
clarkzinzow pushed a commit that referenced this pull request Jan 19, 2023
…enchmark_single_node test (#31752)

The release test read_parquet_benchmark_single_node has been failing for the past several master builds (examples 1, 2), due to the same issue discussed/addressed in #31493 (the actual error message is: botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This PR updates one remaining test to match this convention.

Signed-off-by: Scott Lee <[email protected]>
andreapiso pushed a commit to andreapiso/ray that referenced this pull request Jan 22, 2023
…enchmark_single_node test (ray-project#31752)

The release test read_parquet_benchmark_single_node has been failing for the past several master builds (examples 1, 2), due to the same issue discussed/addressed in ray-project#31493 (the actual error message is: botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This PR updates one remaining test to match this convention.

Signed-off-by: Scott Lee <[email protected]>
Signed-off-by: Andrea Pisoni <[email protected]>
amogkam pushed a commit that referenced this pull request Jan 23, 2023
…tches_benchmark_single_node test (#31864)

The release test iter_tensor_batches_benchmark_single_node has failed the most recent run, due to the same issue discussed/addressed in #31752 and #31493 (the actual error message is: botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This PR updates one remaining test to match this convention.

Signed-off-by: Scott Lee <[email protected]>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
…ay-project#31493)

Signed-off-by: Kai Fricke <[email protected]>

Release tests are currently failing with an error on file upload (botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This is likely because some tests are using an anyscale push-based API to upload files. By switching to the job-based filemanager for all tests the upload issue should be mitigated.

Please note that execution will still happen with SDK commands for those tests that haven't specified to use jobs for execution, so actual test execution should be unaffected.

Signed-off-by: tmynn <[email protected]>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
…ay-project#31493)

Signed-off-by: Kai Fricke <[email protected]>

Release tests are currently failing with an error on file upload (botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This is likely because some tests are using an anyscale push-based API to upload files. By switching to the job-based filemanager for all tests the upload issue should be mitigated.

Please note that execution will still happen with SDK commands for those tests that haven't specified to use jobs for execution, so actual test execution should be unaffected.

Signed-off-by: tmynn <[email protected]>
cadedaniel pushed a commit to cadedaniel/ray that referenced this pull request Mar 22, 2023
…tches_benchmark_single_node test (ray-project#31864)

The release test iter_tensor_batches_benchmark_single_node has failed the most recent run, due to the same issue discussed/addressed in ray-project#31752 and ray-project#31493 (the actual error message is: botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This PR updates one remaining test to match this convention.

Signed-off-by: Scott Lee <[email protected]>
cassidylaidlaw pushed a commit to cassidylaidlaw/ray that referenced this pull request Mar 28, 2023
…enchmark_single_node test (ray-project#31752)

The release test read_parquet_benchmark_single_node has been failing for the past several master builds (examples 1, 2), due to the same issue discussed/addressed in ray-project#31493 (the actual error message is: botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This PR updates one remaining test to match this convention.

Signed-off-by: Scott Lee <[email protected]>
cassidylaidlaw pushed a commit to cassidylaidlaw/ray that referenced this pull request Mar 28, 2023
…tches_benchmark_single_node test (ray-project#31864)

The release test iter_tensor_batches_benchmark_single_node has failed the most recent run, due to the same issue discussed/addressed in ray-project#31752 and ray-project#31493 (the actual error message is: botocore.exceptions.DataNotFoundError: Unable to load data for: ec2/2016-11-15/endpoint-rule-set-1). This PR updates one remaining test to match this convention.

Signed-off-by: Scott Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants