[RLlib] Fix Batch Norm Model flakeyness #31371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
changed the title
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
|
@sven1977 This seems to get rid of flakeyness but might also get rid of testing learning here. Wdyt? |
rllib/examples/batch_norm_model.py
Outdated
| "--time-total-s", | ||
| type=float, | ||
| default=60 * 60, | ||
| help="Time after which we stop " "training in seconds.", |
There was a problem hiding this comment.
typo I'll fix after review 😓
sven1977
reviewed
Jan 3, 2023
sven1977
reviewed
Jan 3, 2023
sven1977
reviewed
Jan 3, 2023
Signed-off-by: Sven Mika <[email protected]>
sven1977
approved these changes
Jan 3, 2023
Signed-off-by: sven1977 <[email protected]>
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Jan 4, 2023
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Jan 4, 2023
…ect#31371) Signed-off-by: Simon Zehnder <[email protected]>
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 16, 2023
…ect#31371) Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…ect#31371) Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…ect#31371) Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst [email protected]
Why are these changes needed?
Our batch norm model tests have been amongst the flakiest of RLLib tests.
This PR aims to reduce this flakiness.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.