Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][state] Task backend - Clean old profiling code [5/n] #31247

Merged
merged 3 commits into from
Dec 21, 2022
Merged

[core][state] Task backend - Clean old profiling code [5/n] #31247

merged 3 commits into from
Dec 21, 2022

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Dec 20, 2022

Signed-off-by: rickyyx [email protected]

Why are these changes needed?

Previous PRs:

In This PR:

  • Remove old code for timeline/profiling backend.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rickyyx
clean clean
644b435 
Signed-off-by: rickyyx <[email protected]>
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 20, 2022
@rickyyx
clean
a22ab96 
Signed-off-by: rickyyx <[email protected]>
@rickyyx
clean
8fc41bf 
Signed-off-by: rickyyx <[email protected]>
@rickyyx rickyyx marked this pull request as ready for review December 21, 2022 21:54
@rickyyx rickyyx added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Dec 21, 2022
@ericl ericl merged commit ad81538 into ray-project:master Dec 21, 2022
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
@rickyyx @AmeerHajAli
[core][state] Task backend - Clean old profiling code [5/n] (#31247)
eab7c61 
**Previous PRs:**
 - #30829: 
 - #30953: 
 - #30867: 
 - #30979: 
 - #30934
 - #31207

**In This PR:** 
- Remove old code for timeline/profiling backend.
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 16, 2023
@rickyyx @tamohannes
[core][state] Task backend - Clean old profiling code [5/n] (ray-proj…
e13a50f 
…ect#31247)

**Previous PRs:**
 - ray-project#30829: 
 - ray-project#30953: 
 - ray-project#30867: 
 - ray-project#30979: 
 - ray-project#30934
 - ray-project#31207

**In This PR:** 
- Remove old code for timeline/profiling backend.

Signed-off-by: tmynn <[email protected]>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
@rickyyx @tamohannes
[core][state] Task backend - Clean old profiling code [5/n] (ray-proj…
42cc28c 
…ect#31247)

**Previous PRs:**
 - ray-project#30829: 
 - ray-project#30953: 
 - ray-project#30867: 
 - ray-project#30979: 
 - ray-project#30934
 - ray-project#31207

**In This PR:** 
- Remove old code for timeline/profiling backend.

Signed-off-by: tmynn <[email protected]>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
@rickyyx @tamohannes
[core][state] Task backend - Clean old profiling code [5/n] (ray-proj…
7a5eec5 
…ect#31247)

**Previous PRs:**
 - ray-project#30829: 
 - ray-project#30953: 
 - ray-project#30867: 
 - ray-project#30979: 
 - ray-project#30934
 - ray-project#31207

**In This PR:** 
- Remove old code for timeline/profiling backend.

Signed-off-by: tmynn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

@rkooo567 rkooo567 rkooo567 approved these changes

@wuisawesome wuisawesome Awaiting requested review from wuisawesome

@AmeerHajAli AmeerHajAli Awaiting requested review from AmeerHajAli

@robertnishihara robertnishihara Awaiting requested review from robertnishihara

@pcmoritz pcmoritz Awaiting requested review from pcmoritz pcmoritz is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@fishbone fishbone Awaiting requested review from fishbone

@scv119 scv119 Awaiting requested review from scv119

Assignees

@ericl ericl

@rkooo567 rkooo567

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickyyx @ericl @rkooo567