Fix a number of trivial typos #31232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyuyeon Kim <[email protected]>
Signed-off-by: Kyuyeon Kim <[email protected]>
architkulkarni
approved these changes
Dec 20, 2022
DmitriGekhtman
approved these changes
Dec 28, 2022
|
Looks like we need more code owner approvals. |
pcmoritz
approved these changes
Dec 28, 2022
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
There were some bunch of trivial typos and were fixed. For migration-example.yaml, num-cpus should be stated as string as mentioned in https://docs.ray.io/en/latest/cluster/kubernetes/user-guides/config.html#num-cpus. * Fix bunches of tiny typos Signed-off-by: Kyuyeon Kim <[email protected]> * Fix one more typo Signed-off-by: Kyuyeon Kim <[email protected]> Signed-off-by: Kyuyeon Kim <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 16, 2023
There were some bunch of trivial typos and were fixed. For migration-example.yaml, num-cpus should be stated as string as mentioned in https://docs.ray.io/en/latest/cluster/kubernetes/user-guides/config.html#num-cpus. * Fix bunches of tiny typos Signed-off-by: Kyuyeon Kim <[email protected]> * Fix one more typo Signed-off-by: Kyuyeon Kim <[email protected]> Signed-off-by: Kyuyeon Kim <[email protected]> Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
There were some bunch of trivial typos and were fixed. For migration-example.yaml, num-cpus should be stated as string as mentioned in https://docs.ray.io/en/latest/cluster/kubernetes/user-guides/config.html#num-cpus. * Fix bunches of tiny typos Signed-off-by: Kyuyeon Kim <[email protected]> * Fix one more typo Signed-off-by: Kyuyeon Kim <[email protected]> Signed-off-by: Kyuyeon Kim <[email protected]> Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
There were some bunch of trivial typos and were fixed. For migration-example.yaml, num-cpus should be stated as string as mentioned in https://docs.ray.io/en/latest/cluster/kubernetes/user-guides/config.html#num-cpus. * Fix bunches of tiny typos Signed-off-by: Kyuyeon Kim <[email protected]> * Fix one more typo Signed-off-by: Kyuyeon Kim <[email protected]> Signed-off-by: Kyuyeon Kim <[email protected]> Signed-off-by: tmynn <[email protected]>
YQ-Wang
pushed a commit
to YQ-Wang/ray
that referenced
this pull request
Jan 26, 2023
There were some bunch of trivial typos and were fixed. For migration-example.yaml, num-cpus should be stated as string as mentioned in https://docs.ray.io/en/latest/cluster/kubernetes/user-guides/config.html#num-cpus. * Fix bunches of tiny typos Signed-off-by: Kyuyeon Kim <[email protected]> * Fix one more typo Signed-off-by: Kyuyeon Kim <[email protected]> Signed-off-by: Kyuyeon Kim <[email protected]> Signed-off-by: Yiqing Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There were some bunch of trivial typos and were fixed.
For migration-example.yaml, num-cpus should be stated as string as mentioned in here.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.