Remove legacy Ray code. #3121

robertnishihara · 2018-10-24T07:10:12Z

This removes the old backend. This is a huge code change.

Currently, this PR removes all the Windows shims because they were under src/common. We'll presumably need to bring some of these back to support Windows, though perhaps it won't be necessary now that we're using asio instead of using sockets directly. We could also leave these in the repository in a different location. Any thoughts @mehrdadn?

TODO:

Need to change back to apache/arrow from robertnishihara/arrow.

This fixes #3128.

AmplabJenkins · 2018-10-24T08:36:52Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8845/
Test FAILed.

chuxi · 2018-10-24T12:51:46Z

Great Job!

guoyuhong · 2018-10-24T15:48:32Z

That's a big milestone!

AmplabJenkins · 2018-10-24T22:24:44Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8854/
Test FAILed.

AmplabJenkins · 2018-10-24T22:39:40Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8855/
Test FAILed.

AmplabJenkins · 2018-10-24T22:44:02Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8858/
Test FAILed.

AmplabJenkins · 2018-10-24T22:49:40Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8856/
Test FAILed.

AmplabJenkins · 2018-10-24T22:54:45Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8857/
Test FAILed.

atumanov · 2018-10-24T22:56:37Z

love this, thanks for doing it, @robertnishihara ! 40K lines of removed code and counting!

AmplabJenkins · 2018-10-24T23:03:01Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8860/
Test FAILed.

AmplabJenkins · 2018-10-24T23:22:27Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8863/
Test FAILed.

mehrdadn · 2018-10-24T23:25:01Z

It's in the git history so there doesn't seem to be any harm right? We can always dig them back up if needed.

robertnishihara · 2018-10-24T23:28:57Z

@mehrdadn sounds good, yeah that should work.

AmplabJenkins · 2018-10-25T01:28:41Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8865/
Test FAILed.

AmplabJenkins · 2018-10-25T02:31:49Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8869/
Test FAILed.

AmplabJenkins · 2018-10-25T06:27:02Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8882/
Test FAILed.

AmplabJenkins · 2018-10-25T07:13:29Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8885/
Test FAILed.

AmplabJenkins · 2018-10-25T08:55:23Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8891/
Test FAILed.

AmplabJenkins · 2018-10-25T09:29:29Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8892/
Test FAILed.

AmplabJenkins · 2018-10-25T20:24:01Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8897/
Test FAILed.

AmplabJenkins · 2018-10-25T20:39:42Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8898/
Test FAILed.

AmplabJenkins · 2018-10-26T00:36:26Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8900/
Test FAILed.

AmplabJenkins · 2018-10-26T00:43:34Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8903/
Test FAILed.

AmplabJenkins · 2018-10-26T03:34:27Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8910/
Test FAILed.

AmplabJenkins · 2018-10-26T05:32:12Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8912/
Test FAILed.

AmplabJenkins · 2018-10-26T09:51:00Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8915/
Test FAILed.

AmplabJenkins · 2018-10-26T10:05:06Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8916/
Test FAILed.

robertnishihara · 2018-10-26T17:14:55Z

jenkins, retest this please

AmplabJenkins · 2018-10-26T18:51:07Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8917/
Test PASSed.

pcmoritz · 2018-10-26T18:56:22Z

src/ray/raylet/local_scheduler_client.cc

+ &conn->write_mutex);
+}
+
+// const std::vector<uint8_t> local_scheduler_get_actor_frontier(


can you remove this?

pcmoritz · 2018-10-26T18:56:47Z

src/ray/raylet/lib/python/local_scheduler_extension.cc

- ((PyLocalSchedulerClient *) self)->local_scheduler_connection, frontier);
- Py_RETURN_NONE;
-}
+// static PyObject *PyLocalSchedulerClient_get_actor_frontier(PyObject *self,


can you remove this?

pcmoritz · 2018-10-26T18:57:05Z

src/ray/raylet/lib/python/local_scheduler_extension.cc

- {"set_actor_frontier",
- (PyCFunction) PyLocalSchedulerClient_set_actor_frontier, METH_VARARGS, ""},
- {"wait", (PyCFunction) PyLocalSchedulerClient_wait, METH_VARARGS,
+ // {"get_actor_frontier",


remove this

pcmoritz · 2018-10-26T18:59:45Z

src/ray/gcs/tables.h

- SchedulingState test_state_bitmask,
- SchedulingState update_state,
- const TaskTable::TestAndUpdateCallback &callback);
+// class TaskTable : public Table<TaskID, TaskTableData> {


remove this

AmplabJenkins · 2018-10-26T20:34:28Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/8918/
Test PASSed.

robertnishihara force-pushed the removelegacyray branch from f7b5c9b to f81727f Compare October 24, 2018 23:27

robertnishihara force-pushed the removelegacyray branch from f81727f to 176e316 Compare October 25, 2018 00:44

robertnishihara and others added 11 commits October 25, 2018 00:33

Remove legacy Ray code.

3cec358

Fix cmake and simplify monitor.

e4aa7d1

Fix linting

dd17386

Updates

b8649f8

Fix

9225932

Implement some methods.

e5adb9c

Remove more plasma manager references.

83c20e1

Fix

03af5a5

Linting

1069e03

Fix

facab7b

Fix

8a22898

linting

7f29bb7

robertnishihara added 2 commits October 25, 2018 11:57

Fixes

685d9ce

Java fixes

ebffc6b

Ubuntu and others added 2 commits October 25, 2018 23:06

Some java fixes

de422e6

TaskLanguage -> Language

1b8676d

Minor

39b7a83

Fix python test and remove unused method signature.

20eaf7c

robertnishihara added 2 commits October 26, 2018 01:22

Fix java tests

91e02ba

Fix jenkins tests

6a5a919

pcmoritz reviewed Oct 26, 2018

View reviewed changes

Remove commented out code.

fda603d

pcmoritz approved these changes Oct 26, 2018

View reviewed changes

pcmoritz merged commit 658c142 into ray-project:master Oct 26, 2018

robertnishihara deleted the removelegacyray branch October 26, 2018 20:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove legacy Ray code. #3121

Remove legacy Ray code. #3121

robertnishihara commented Oct 24, 2018 •

edited

Loading

AmplabJenkins commented Oct 24, 2018

chuxi commented Oct 24, 2018

guoyuhong commented Oct 24, 2018 •

edited

Loading

AmplabJenkins commented Oct 24, 2018

AmplabJenkins commented Oct 24, 2018

AmplabJenkins commented Oct 24, 2018

AmplabJenkins commented Oct 24, 2018

AmplabJenkins commented Oct 24, 2018

atumanov commented Oct 24, 2018

AmplabJenkins commented Oct 24, 2018

AmplabJenkins commented Oct 24, 2018

mehrdadn commented Oct 24, 2018

robertnishihara commented Oct 24, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

robertnishihara commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

pcmoritz Oct 26, 2018

pcmoritz Oct 26, 2018

pcmoritz Oct 26, 2018

pcmoritz Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

Remove legacy Ray code. #3121

Remove legacy Ray code. #3121

Conversation

robertnishihara commented Oct 24, 2018 • edited Loading

AmplabJenkins commented Oct 24, 2018

chuxi commented Oct 24, 2018

guoyuhong commented Oct 24, 2018 • edited Loading

AmplabJenkins commented Oct 24, 2018

AmplabJenkins commented Oct 24, 2018

AmplabJenkins commented Oct 24, 2018

AmplabJenkins commented Oct 24, 2018

AmplabJenkins commented Oct 24, 2018

atumanov commented Oct 24, 2018

AmplabJenkins commented Oct 24, 2018

AmplabJenkins commented Oct 24, 2018

mehrdadn commented Oct 24, 2018

robertnishihara commented Oct 24, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 25, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

robertnishihara commented Oct 26, 2018

AmplabJenkins commented Oct 26, 2018

pcmoritz Oct 26, 2018

Choose a reason for hiding this comment

pcmoritz Oct 26, 2018

Choose a reason for hiding this comment

pcmoritz Oct 26, 2018

Choose a reason for hiding this comment

pcmoritz Oct 26, 2018

Choose a reason for hiding this comment

AmplabJenkins commented Oct 26, 2018

robertnishihara commented Oct 24, 2018 •

edited

Loading

guoyuhong commented Oct 24, 2018 •

edited

Loading