[RLlib] Fix erroring our when tuning any algo without torch being installed #31177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
sven1977
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Looks good to me. Thanks for the fix @ArturNiederfahrenhorst !
Capiru
pushed a commit
to Capiru/ray
that referenced
this pull request
Dec 22, 2022
…talled. (ray-project#31177) Signed-off-by: Capiru <[email protected]>
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 16, 2023
…talled. (ray-project#31177) Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…talled. (ray-project#31177) Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…talled. (ray-project#31177) Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst [email protected]
Why are these changes needed?
Makes it so that tune can register QMix even though torch is not installed.
We don't error out on import for torch specific Algorithms in general, QMix should not be an exception.
This PR does not fix the root cause of this behaviour, which is that we import stuff that can not be used.
This PR goes the same way as other Algorithms that only work for torch.
Related issue number
#31176
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.