[Dashboard] Support job-scoped actor + placement group page to the JobDetail page #31062
Conversation
Signed-off-by: SangBin Cho <[email protected]>
| @@ -369,6 +369,8 @@ class PlacementGroupState(StateSchema): | |||
| placement_group_id: str = state_column(filterable=True) | |||
| #: The name of the placement group if it is given by the name argument. | |||
| name: str = state_column(filterable=True) | |||
| #: The job id of the placement group. | |||
| creator_job_id: str = state_column(filterable=True) | |||
There was a problem hiding this comment.
we need to change the name of this column. It will be tracked as TODO
There was a problem hiding this comment.
in the frontend, it will be displayed as "job id"
| </TableCell> | ||
| <TableCell align="center">{name ? name : "-"}</TableCell> | ||
| <TableCell align="center">{creator_job_id}</TableCell> | ||
| <TableCell align="center"> |
There was a problem hiding this comment.
TODO we need a bundle specification
There was a problem hiding this comment.
will do as a follow up in the future PR
| }} | ||
| /> | ||
| </div> | ||
| <div style={{ display: "flex", alignItems: "center" }}> |
There was a problem hiding this comment.
I know this is existing pattern but direct inlining styles is frowned upon because of low composibility.
I hoped we could go in polish each page and rewrite with better code style before adding too much new content.
There was a problem hiding this comment.
What does it take to do that? I mostly copied & pasted existing actor table (and I feel bad about it). Alternative idea is to do clean up as a part of "cleaning tech debt" after 2.3. I feel like the amount of code we have is small enough that we can proceed this way.
There was a problem hiding this comment.
for this part, I will avoid inlined style... is the preferred style using classes? Or do we have a doc for the frontend code guideline? (if so can you share it? )
There was a problem hiding this comment.
yes, classes are preferred.
There was a problem hiding this comment.
hmm I found refactoring this is actually much bigger efforts that I thought. Let's refactor all at once?
Signed-off-by: SangBin Cho <[email protected]>
|
Addressed code review + I also added the task table. |
| @@ -1 +1,3 @@ | |||
| export const API_REFRESH_INTERVAL_MS = 4000; | |||
| // Per job page refresh interval. | |||
| export const PER_JOB_PAGE_REFRESH_INTERVAL_MS = 10000; | |||
There was a problem hiding this comment.
4 seconds are too short and I don't think it is that useful for actor/task/pg tables. We can reduce the frequency later when we optimize tables (pagination)
| /> | ||
| </div> | ||
| </div> | ||
| <Table> |
There was a problem hiding this comment.
TODO add a status chip later. Now it is not possible because of the field name (status chip only works with a name "state", but task APi provides "scheduling_state")
|
|
| }} | ||
| /> | ||
| </div> | ||
| <div style={{ display: "flex", alignItems: "center" }}> |
There was a problem hiding this comment.
yes, classes are preferred.
Signed-off-by: SangBin Cho <[email protected]>
…bDetail page (ray-project#31062) Signed-off-by: SangBin Cho <[email protected]> Add a job-scoped actor page to the job detail page Add a placement group table and add it to the job detail page. Add a task table Signed-off-by: Weichen Xu <[email protected]>
…bDetail page (ray-project#31062) Signed-off-by: SangBin Cho <[email protected]> Add a job-scoped actor page to the job detail page Add a placement group table and add it to the job detail page. Add a task table Signed-off-by: Capiru <[email protected]>
…bDetail page (#31062) Signed-off-by: SangBin Cho <[email protected]> Add a job-scoped actor page to the job detail page Add a placement group table and add it to the job detail page. Add a task table
…bDetail page (ray-project#31062) Signed-off-by: SangBin Cho <[email protected]> Add a job-scoped actor page to the job detail page Add a placement group table and add it to the job detail page. Add a task table Signed-off-by: tmynn <[email protected]>
…bDetail page (ray-project#31062) Signed-off-by: SangBin Cho <[email protected]> Add a job-scoped actor page to the job detail page Add a placement group table and add it to the job detail page. Add a task table Signed-off-by: tmynn <[email protected]>
…bDetail page (ray-project#31062) Signed-off-by: SangBin Cho <[email protected]> Add a job-scoped actor page to the job detail page Add a placement group table and add it to the job detail page. Add a task table Signed-off-by: tmynn <[email protected]>
Signed-off-by: SangBin Cho [email protected]
Why are these changes needed?
Couple TODOs
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.