Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lightning] Update Lightning documentation to test all code snippets #30560

Merged
merged 11 commits into from
Nov 23, 2022

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Nov 22, 2022

Signed-off-by: amogkam [email protected]

Update the documentation to most recent Ray Lightning version. Also makes sure all the code snippets are tested. Addresses https://ray-distributed.slack.com/archives/C01DLHZHRBJ/p1669046595901749

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it seems CI is still failing

Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Signed-off-by: amogkam <[email protected]>
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@amogkam amogkam merged commit 7f2cff3 into ray-project:master Nov 23, 2022
@amogkam amogkam deleted the fix-ptl-docs branch November 23, 2022 23:52
scottjlee pushed a commit to scottjlee/ray that referenced this pull request Dec 5, 2022
…ay-project#30560)

Signed-off-by: amogkam [email protected]

Update the documentation to most recent Ray Lightning version. Also makes sure all the code snippets are tested. Addresses https://ray-distributed.slack.com/archives/C01DLHZHRBJ/p1669046595901749

Signed-off-by: Scott Lee <[email protected]>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Dec 16, 2022
…ay-project#30560)

Signed-off-by: amogkam [email protected]

Update the documentation to most recent Ray Lightning version. Also makes sure all the code snippets are tested. Addresses https://ray-distributed.slack.com/archives/C01DLHZHRBJ/p1669046595901749
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…ay-project#30560)

Signed-off-by: amogkam [email protected]

Update the documentation to most recent Ray Lightning version. Also makes sure all the code snippets are tested. Addresses https://ray-distributed.slack.com/archives/C01DLHZHRBJ/p1669046595901749

Signed-off-by: Weichen Xu <[email protected]>
Capiru pushed a commit to Capiru/ray that referenced this pull request Dec 21, 2022
…ay-project#30560)

Signed-off-by: amogkam [email protected]

Update the documentation to most recent Ray Lightning version. Also makes sure all the code snippets are tested. Addresses https://ray-distributed.slack.com/archives/C01DLHZHRBJ/p1669046595901749

Signed-off-by: Capiru <[email protected]>
Capiru pushed a commit to Capiru/ray that referenced this pull request Dec 21, 2022
…ay-project#30560)

Signed-off-by: amogkam [email protected]

Update the documentation to most recent Ray Lightning version. Also makes sure all the code snippets are tested. Addresses https://ray-distributed.slack.com/archives/C01DLHZHRBJ/p1669046595901749

Signed-off-by: Capiru <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants