[RLlib] Enable connectors #30388
Merged
[RLlib] Enable connectors #30388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
|
Not needed anymore. |
|
awesome man!! test_tune_restore is the only broken test, and kourosh and I have a PR. |
sven1977
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
LGTM! Awesome stuff guys. Thanks for making this happen: @ArturNiederfahrenhorst , @kouroshHakha , @avnishn , @gjoliver !!
|
Some tune test is failing. Please make sure this is fixed before merging, @gjoliver . |
|
#30635 is in. can you rebase? |
ArturNiederfahrenhorst
force-pushed
the
enableconnectors2
branch
from
1dcc701
to
c1db009
Compare
ArturNiederfahrenhorst
force-pushed
the
enableconnectors2
branch
from
293c0af
to
2ad20f7
Compare
gjoliver
approved these changes
Dec 15, 2022
gjoliver
force-pushed
the
enableconnectors2
branch
from
f5782f8
to
21ccbe0
Compare
ArturNiederfahrenhorst
force-pushed
the
enableconnectors2
branch
from
21ccbe0
to
891c6a5
Compare
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Jun Gong <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
force-pushed
the
enableconnectors2
branch
from
891c6a5
to
a7f666b
Compare
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
added a commit
to ArturNiederfahrenhorst/ray
that referenced
this pull request
Jan 6, 2023
This reverts commit 9f2b369.
sven1977
pushed a commit
that referenced
this pull request
Jan 6, 2023
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 16, 2023
Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 16, 2023
…31495) Signed-off-by: tmynn <[email protected]>
ArturNiederfahrenhorst
added a commit
to ArturNiederfahrenhorst/ray
that referenced
this pull request
Jan 18, 2023
…project#31495)" This reverts commit ee3abd4.
ArturNiederfahrenhorst
added a commit
to ArturNiederfahrenhorst/ray
that referenced
this pull request
Jan 19, 2023
…project#31495)" This reverts commit ee3abd4.
gjoliver
pushed a commit
that referenced
this pull request
Jan 19, 2023
andreapiso
pushed a commit
to andreapiso/ray
that referenced
this pull request
Jan 22, 2023
…project#31495)" (ray-project#31733) Flip default value for enable_connectors flag. Signed-off-by: Andrea Pisoni <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…31495) Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…31495) Signed-off-by: tmynn <[email protected]>
cassidylaidlaw
pushed a commit
to cassidylaidlaw/ray
that referenced
this pull request
Mar 28, 2023
…project#31495)" (ray-project#31733) Flip default value for enable_connectors flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst [email protected]
PR to track master with connectors enabled.
Different than #30199 in that it does not contain in-flight PRs.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.