Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ml-release][no_ci] Do not output progress bar for air tf benchmark. #30310

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

xwjiang2010
Copy link
Contributor

@xwjiang2010 xwjiang2010 commented Nov 15, 2022

Signed-off-by: xwjiang2010 [email protected]

Why are these changes needed?

Release test log is highly polluted by pyramid shaped progress bar in remote actors.

See https://console.anyscale-staging.com/o/anyscale-internal/projects/prj_qC3ZfndQWYYjx2cz8KWGNUL4/clusters/ses_nBJeS1ag1Ys4kByHP9LZBXNB?command-history-section=command_history

Debugging is hence very difficult.

Related issue number

#29922

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010 xwjiang2010 changed the title [ml-release] Do not output progress bar for air tf benchmark. [ml-release][no_ci] Do not output progress bar for air tf benchmark. Nov 15, 2022
Signed-off-by: xwjiang2010 <[email protected]>
@amogkam amogkam merged commit d4d1ab1 into ray-project:master Nov 15, 2022
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Dec 16, 2022
…ay-project#30310)

Release test log is highly polluted by pyramid shaped progress bar in remote actors.

Signed-off-by: Amog Kamsetty <[email protected]>
Co-authored-by: Amog Kamsetty <[email protected]>
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…ay-project#30310)

Release test log is highly polluted by pyramid shaped progress bar in remote actors.

Signed-off-by: Amog Kamsetty <[email protected]>
Co-authored-by: Amog Kamsetty <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
@xwjiang2010 xwjiang2010 deleted the fix_tf_mnist_benchmark branch July 26, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants