[Serve][Release Test][HA] Wait for locust pod ready #30010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihan Wang <[email protected]>
edoakes
approved these changes
Nov 4, 2022
| print("Wait for locust pod is ready...") | ||
| time.sleep(30) | ||
| timeout_wait_for_locust_s -= 30 | ||
| else: |
There was a problem hiding this comment.
does it make sense to explicitly check for success/errored states?
There was a problem hiding this comment.
When other state, it will fail under the port forwarding eventually.
In the port forwarding step, it will complain something like
error: unable to forward port because pod is not running. Current status=Pending
So i don't bother to check other status. (easy to debug)
Signed-off-by: Sihan Wang <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihan Wang [email protected]
Why are these changes needed?
Port forwarding sometimes failed since the locust pod is not ready
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.