Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Remove deprecated execution plan API code. #29941

Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Nov 2, 2022

Signed-off-by: sven1977 [email protected]

  • Remove deprecated execution plan API code as far as possible.
  • MB-MPO and MAML remain the only algos using the execution plan API.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>
Copy link
Member

@avnishn avnishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome possum. Just one tiny bit about a grammar thing. Feel free to ignore I think people will still understand.

your own algorithm logic. You can find the different built-in
algorithms' execution plans in their respective main py files,
algorithms' `training_step`s in their respective main .py files,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace training_steps w training_step functions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed.

Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 merged commit d9b92eb into ray-project:master Nov 2, 2022
@cadedaniel
Copy link
Member

@sven1977 This broke LinkCheck
Screen Shot 2022-11-02 at 11 04 47 AM

kouroshHakha added a commit to kouroshHakha/ray that referenced this pull request Nov 2, 2022
gjoliver pushed a commit that referenced this pull request Nov 2, 2022
sven1977 added a commit that referenced this pull request Nov 3, 2022
NKcqx pushed a commit to NKcqx/ray that referenced this pull request Nov 8, 2022
NKcqx pushed a commit to NKcqx/ray that referenced this pull request Nov 8, 2022
NKcqx pushed a commit to NKcqx/ray that referenced this pull request Nov 8, 2022
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Dec 16, 2022
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Dec 16, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@sven1977 sven1977 deleted the deprecate_execution_plan_api_01 branch June 2, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants