-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix Windows Wheel flaky build caused by ', using heredoc in refreshenv. #29903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadedaniel
changed the title
Fix Windows Wheel flaky build by using heredoc in refreshenv
[CI] Fix Windows Wheel flaky build by using heredoc in refreshenv
Nov 1, 2022
jjyao
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a single quote to the commit message to make sure it works :)
haha, sure :) |
cadedaniel
changed the title
[CI] Fix Windows Wheel flaky build by using heredoc in refreshenv
[CI] Fix Windows Wheel flaky build caused by ', using heredoc in refreshenv.
Nov 1, 2022
@jjyao my edit will go into the merge commit, right? |
Signed-off-by: Cade Daniel <[email protected]>
cadedaniel
force-pushed
the
heredoc-refreshenv
branch
from
November 1, 2022 19:32
a2d3fb2
to
db24683
Compare
@jjyao merge please |
🤔🤔🤔🤔
|
NKcqx
pushed a commit
to NKcqx/ray
that referenced
this pull request
Nov 8, 2022
…eshenv. (ray-project#29903) See ray-project#29878 and ray-project#29717 for context. TL;DR there is a script which exports environment variables present in powershell to bash, but it fails to handle cases where environment variable values contain single quotes. This causes the Windows Wheels build to fail whenever an environment variable value contains a single quote, particularly when the commit message has a single quote (common!). I fixed it by exporting the variables using bash heredocs which are more robust against arbitrary input values. Signed-off-by: Cade Daniel <[email protected]> Signed-off-by: JasonChen <[email protected]>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Dec 16, 2022
…eshenv. (ray-project#29903) See ray-project#29878 and ray-project#29717 for context. TL;DR there is a script which exports environment variables present in powershell to bash, but it fails to handle cases where environment variable values contain single quotes. This causes the Windows Wheels build to fail whenever an environment variable value contains a single quote, particularly when the commit message has a single quote (common!). I fixed it by exporting the variables using bash heredocs which are more robust against arbitrary input values. Signed-off-by: Cade Daniel <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…eshenv. (ray-project#29903) See ray-project#29878 and ray-project#29717 for context. TL;DR there is a script which exports environment variables present in powershell to bash, but it fails to handle cases where environment variable values contain single quotes. This causes the Windows Wheels build to fail whenever an environment variable value contains a single quote, particularly when the commit message has a single quote (common!). I fixed it by exporting the variables using bash heredocs which are more robust against arbitrary input values. Signed-off-by: Cade Daniel <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #29878 and #29717 for context.
TL;DR there is a script which exports environment variables present in powershell to bash, but it fails to handle cases where environment variable values contain single quotes. This causes the Windows Wheels build to fail whenever an environment variable value contains a single quote, particularly when the commit message has a single quote (common!). I fixed it by exporting the variables using bash heredocs which are more robust against arbitrary input values.
Testing
Powershell code to test:
Test runner (COMPLEX_ENV_VAR_1 has single quotes):
Output:
It worked! Without the
heredoc
, it gets borked: