Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Java flaky test. #29760

Merged
merged 2 commits into from
Oct 28, 2022
Merged

Fix Java flaky test. #29760

merged 2 commits into from
Oct 28, 2022

Conversation

jovany-wang
Copy link
Contributor

Why are these changes needed?

The cases fail with timeout because of a short time to get objects from actors. We fix it by increase them.

Related issue number

#29672

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jovany-wang
Fix another one.
f4c3915 
Signed-off-by: Qing Wang <[email protected]>
@jovany-wang
Copy link
Contributor Author

@tomsunelite CC

@jovany-wang jovany-wang mentioned this pull request Oct 27, 2022
Closed
@jjyao
Copy link
Collaborator

jjyao commented Oct 27, 2022

Is there any perf regression? Why did the short timeout work before?

@jjyao jjyao added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Oct 27, 2022
@cadedaniel cadedaniel linked an issue Oct 27, 2022 that may be closed by this pull request
[CI] bk:https://:mac: :apple: Ray C++ and Java is failing/flaky on master. #29672
Closed
@jovany-wang
Copy link
Contributor Author

jovany-wang commented Oct 28, 2022 •
edited
Loading

@jjyao The cases were introduced recently, I believe on a terrible machine, it should take seconds to start a java worker due to the heavy JVM. So it's reasonable that they are flaky somehow.

Before #28367 , the Ray.get() is without timeout.
So I don't think there is any regression, at least for these cases.

@jovany-wang jovany-wang removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Oct 28, 2022
@jovany-wang jovany-wang merged commit 3f6fec2 into ray-project:master Oct 28, 2022
@jovany-wang jovany-wang deleted the fix-java-flaky branch October 28, 2022 03:25
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@jovany-wang @WeichenXu123
Fix Java flaky test. (ray-project#29760)
5a93150 
The cases fail with timeout because of a short time to get objects from actors. We fix it by increase them.

Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjyao jjyao jjyao approved these changes

Assignees

@jjyao jjyao

@cadedaniel cadedaniel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] bk:https://:mac: :apple: Ray C++ and Java is failing/flaky on master.
3 participants
@jovany-wang @jjyao @cadedaniel