[RLlib] IMPALA: Move learner thread health-check into better place. #29541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
maxpumperla
approved these changes
Oct 21, 2022
xcharleslin
pushed a commit
that referenced
this pull request
Oct 21, 2022
…29541) Signed-off-by: Xiayue Charles Lin <[email protected]>
cadedaniel
pushed a commit
to cadedaniel/ray
that referenced
this pull request
Oct 25, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ay-project#29541) Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sven1977 [email protected]
The current learner-thread health check in IMPALA/APPO is located inside a for loop, which might not get entered if the learner thread has already died, so the check is quite useless.
Moved it to the beginning of the
training_stepmethod ("to the surface").Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.