Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[air/ci] Bump two test suite sizes #29357

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Oct 14, 2022

Signed-off-by: Kai Fricke [email protected]

Why are these changes needed?

We recently lowered the test instance sizes across the board. Two test suites began failing after #29295 were merged (at least one of the suites is only run on branch builds, so we missed it).

I'll run the tests on a repro CI instance to confirm they work on the larger instances.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke
Copy link
Contributor Author

Passes locally

@krfricke krfricke merged commit b823bdf into ray-project:master Oct 14, 2022
@krfricke krfricke deleted the ci/bump-sizes branch October 14, 2022 16:55
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
We recently lowered the test instance sizes across the board. Two test suites began failing after ray-project#29295 were merged (at least one of the suites is only run on branch builds, so we missed it).

I'll run the tests on a repro CI instance to confirm they work on the larger instances.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants