Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert floats to integers before using randrange #28962

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Convert floats to integers before using randrange #28962

merged 1 commit into from
Oct 6, 2022

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Oct 1, 2022 •
edited
Loading

Why are these changes needed?

Some lines in RLlib cause this warning:

DeprecationWarning: non-integer arguments to randrange() have been deprecated since Python 3.10 and will be removed in a subsequent version

Related issue number

Fixes #28961

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@cool-RR cool-RR marked this pull request as ready for review October 1, 2022 17:46
@cool-RR
Copy link
Contributor Author

cool-RR commented Oct 4, 2022

@sven1977 Can you review please?

@gjoliver gjoliver merged commit f448e33 into ray-project:master Oct 6, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@cool-RR @WeichenXu123
Convert floats to integers before using randrange (ray-project#28962)
18051ad 
Signed-off-by: Ram Rachum <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjoliver gjoliver gjoliver approved these changes

@sven1977 sven1977 Awaiting requested review from sven1977 sven1977 is a code owner

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst ArturNiederfahrenhorst is a code owner

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

@krfricke krfricke Awaiting requested review from krfricke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RLlib] Fix "DeprecationWarning: non-integer arguments to randrange()"
2 participants
@cool-RR @gjoliver