-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Better support MultiBinary spaces by treating Tuples as superset of them in ComplexInputNet #28900
[RLlib] Better support MultiBinary spaces by treating Tuples as superset of them in ComplexInputNet #28900
Conversation
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Do any code owners have time to review this? |
Before they review there is a test that's failing. I'll have to have another look at it soon! |
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message. Please feel free to reopen or open a new issue if you'd still like it to be addressed. Again, you can always ask for help on our discussion forum or Ray's public slack channel. Thanks again for opening the issue! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
f0609a4
to
604533e
Compare
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
…set of them in ComplexInputNet. (#28900)
…set of them in ComplexInputNet. (ray-project#28900) Signed-off-by: tmynn <[email protected]>
…set of them in ComplexInputNet. (ray-project#28900) Signed-off-by: tmynn <[email protected]>
…set of them in ComplexInputNet. (ray-project#28900) Signed-off-by: Yiqing Wang <[email protected]>
Signed-off-by: Artur Niederfahrenhorst [email protected]
Why are these changes needed?
This PR solves two issues that are both encapsulated in the issue referred below. Both issues are with the ComplexInputNet.
Related issue number
Closes #28605
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.