Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Better support MultiBinary spaces by treating Tuples as superset of them in ComplexInputNet #28900

Merged

Conversation

ArturNiederfahrenhorst
Copy link
Contributor

Signed-off-by: Artur Niederfahrenhorst [email protected]

Why are these changes needed?

This PR solves two issues that are both encapsulated in the issue referred below. Both issues are with the ComplexInputNet.

  1. If a component of an obs space has three dimensions, we assume it's an image (this only makes sense for a Box)
  2. We don't represent the MultiBinary space (which is closely related to a Tuple). I argue that it's easier to simply treat MultiBinary as a Tuple than telling users to use Tuples.

Related issue number

Closes #28605

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
@ArturNiederfahrenhorst ArturNiederfahrenhorst changed the title [RLlib] Better support MultiBinary spaces by treating them as supersets of Tuples in ComplexInputNet [RLlib] Better support MultiBinary spaces by treating Tuples as superset of them in ComplexInputNet Oct 3, 2022
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
@cool-RR
Copy link
Contributor

cool-RR commented Oct 7, 2022

Do any code owners have time to review this?

@ArturNiederfahrenhorst
Copy link
Contributor Author

Before they review there is a test that's failing. I'll have to have another look at it soon!

@stale
Copy link

stale bot commented Nov 12, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Nov 12, 2022
@stale
Copy link

stale bot commented Nov 26, 2022

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this Nov 26, 2022
@sven1977 sven1977 reopened this Dec 22, 2022
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Dec 22, 2022
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
@sven1977 sven1977 merged commit f8ae481 into ray-project:master Jan 3, 2023
@ArturNiederfahrenhorst ArturNiederfahrenhorst deleted the MultiDiscreteComplexModel branch January 5, 2023 15:39
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
YQ-Wang pushed a commit to YQ-Wang/ray that referenced this pull request Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RLlib: RecursionError when using MultiBinary space
3 participants