Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Disable ML compat tests on Windows #28821

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Sep 27, 2022

Signed-off-by: Amog Kamsetty [email protected]

ML tests should not be run on Windows

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Amog Kamsetty <[email protected]>
@amogkam
Copy link
Contributor Author

amogkam commented Sep 27, 2022

The windows failure is failing on master as well. Going to merge.

@amogkam amogkam merged commit 3034767 into ray-project:master Sep 27, 2022
@amogkam amogkam deleted the disable-ml-compat-test-windows branch September 27, 2022 21:58
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
Signed-off-by: Amog Kamsetty [email protected]

ML tests should not be run on Windows

Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants