Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] [Release] Disable OOM killer for XGBoost AIR test #28819

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Sep 27, 2022

Signed-off-by: Amog Kamsetty [email protected]

OOM killer has been causing the XGBoost AIR test to fail. We disable it for now to get the test passing.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Amog Kamsetty <[email protected]>
@krfricke
Copy link
Contributor

Btw @amogkam if you want to run release tests on a PR that doesn't generate a wheel (like this one), just put master in the "Ray wheels" section and it will run the test with the latest available master wheels.

@amogkam amogkam merged commit 4fff41c into ray-project:master Sep 28, 2022
@amogkam amogkam deleted the xgboost-air-test-disable-oom branch September 28, 2022 15:14
@scv119
Copy link
Contributor

scv119 commented Sep 28, 2022

@amogkam do you have a test instance it failed? we can look into. cc @clarng

@amogkam
Copy link
Contributor Author

amogkam commented Sep 28, 2022

@clarng
Copy link
Contributor

clarng commented Sep 28, 2022 via email

WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…28819)

Signed-off-by: Amog Kamsetty [email protected]

OOM killer has been causing the XGBoost AIR test to fail. We disable it for now to get the test passing.

Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants