Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add m5.2xlarge target to more test suites #28749

Merged
merged 2 commits into from
Sep 24, 2022

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Sep 24, 2022

Signed-off-by: Amog Kamsetty [email protected]

Follow up to #28736

Add m5.2xlarge target to the remaining test suites that require it.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Amog Kamsetty <[email protected]>
@matthewdeng
Copy link
Contributor

@krfricke @amogkam do we have general guidelines for which tests should use which instances? Is the limiting factor memory or something else?

Copy link
Member

@jiaodong jiaodong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_batchpredictor_runtime failed due to failing 15secs time check

Signed-off-by: Kai Fricke <[email protected]>
@krfricke krfricke merged commit 01fc441 into ray-project:master Sep 24, 2022
@amogkam
Copy link
Contributor Author

amogkam commented Sep 26, 2022

@matthewdeng All tests should probably be able to use smaller instances, but would require some rewriting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants