Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] [Train] Update Train API reference and docs #28192

Merged
merged 4 commits into from
Sep 2, 2022

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Aug 31, 2022

Signed-off-by: Amog Kamsetty [email protected]

Adds back more Ray Train APIs to Ray Train docs.

Also makes updates to the user guide for better references.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Amog Kamsetty <[email protected]>
@amogkam amogkam changed the title [Docs] [Train] Add Train function util APIs back to docs [Docs] [Train] Update Train API reference and docs Aug 31, 2022
@amogkam amogkam self-assigned this Aug 31, 2022
Signed-off-by: Amog Kamsetty <[email protected]>
@@ -7,6 +7,73 @@ This page covers advanced configurations for specific frameworks using Train.

For different high level trainers and their usage, take a look at the :ref:`AIR Trainer package reference <air-trainer-ref>`.

.. _train-api-torch-utils:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idts- these are not part of the AIR session API

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then why do we need :no-index:?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR, PTAL!

Signed-off-by: Amog Kamsetty <[email protected]>
Signed-off-by: Amog Kamsetty <[email protected]>
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, love it!

@amogkam
Copy link
Contributor Author

amogkam commented Sep 2, 2022

Failing tests are fixed on master

@amogkam amogkam merged commit b83f10d into ray-project:master Sep 2, 2022
@amogkam amogkam deleted the add-back-train-apis branch September 2, 2022 00:47
XiaodongLv pushed a commit to XiaodongLv/ray that referenced this pull request Sep 2, 2022
Signed-off-by: Amog Kamsetty [email protected]

Adds back more Ray Train APIs to Ray Train docs.

Also makes updates to the user guide for better references.
ilee300a pushed a commit to ilee300a/ray that referenced this pull request Sep 12, 2022
Signed-off-by: Amog Kamsetty [email protected]

Adds back more Ray Train APIs to Ray Train docs.

Also makes updates to the user guide for better references.

Signed-off-by: ilee300a <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants