Revert "Replace boost::filesystem with std::filesystem (#27338)" #27483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyao
approved these changes
Aug 4, 2022
|
cc @jjyao to follow up |
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
…7338)" (ray-project#27483) This reverts commit c50faa1. Signed-off-by: Scott Graham <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
…7338)" (ray-project#27483) This reverts commit c50faa1.
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…7338)" (ray-project#27483) This reverts commit c50faa1. Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c50faa1.
Why are these changes needed?
This PR breaks MacOS fallback allocation test
-> this PR https://buildkite.com/ray-project/ray-builders-branch/builds/9143#01825be5-c59d-4521-b2d4-ef64ff26d9de
-> previous PR https://buildkite.com/ray-project/ray-builders-branch/builds/9142#01825be0-7fd2-497b-a592-590c1de43b86
It wasn't caught because MacOS build is giving false positive signals now
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.