[Serve] Gate the deprecation warnings behind envvar #27479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: simon-mo <[email protected]>
sihanwang41
approved these changes
Aug 4, 2022
edoakes
reviewed
Aug 4, 2022
python/ray/serve/_private/utils.py
Outdated
| @@ -428,3 +428,17 @@ def in_interactive_shell(): | |||
| import __main__ as main | |||
|
|
|||
| return not hasattr(main, "__file__") | |||
|
|
|||
|
|
|||
| def deprecated(*args, **kwargs): | |||
There was a problem hiding this comment.
can we call this deprecation_warning instead of deprecated so it's less confusing with the existing ray core-level Deprecated decorator?
There was a problem hiding this comment.
changed it to guarded_deprecation_warning for extra verbosity
Signed-off-by: simon-mo <[email protected]>
simon-mo
added a commit
to simon-mo/ray
that referenced
this pull request
Aug 5, 2022
simon-mo
added a commit
that referenced
this pull request
Aug 5, 2022
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR makes the deprecation warnings optional when user are using the API. Deprecation will still show up in the docstring regardless; but the warnings will be disabled by default.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.