Revert "Revert "[Serve] ServeHandle detects ActorError and drop replicas from target group (#26685)" (#27283)" #27348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cas from target group (ray-project#26685)" (ray-project#27283)" This reverts commit 1a10b53.
Signed-off-by: simon-mo <[email protected]>
fishbone
approved these changes
Aug 1, 2022
Signed-off-by: simon-mo <[email protected]>
|
@simon-mo is this a release blocker? also the windows test is failing. |
|
Windows passed with retry. There's already a cherry-pick PR, let me update that. |
simon-mo
added a commit
to simon-mo/ray
that referenced
this pull request
Aug 3, 2022
…icas from target group (ray-project#26685)" (ray-project#27283)" (ray-project#27348) Signed-off-by: simon-mo <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
…icas from target group (ray-project#26685)" (ray-project#27283)" (ray-project#27348) Signed-off-by: Scott Graham <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
…icas from target group (ray-project#26685)" (ray-project#27283)" (ray-project#27348)
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…icas from target group (ray-project#26685)" (ray-project#27283)" (ray-project#27348) Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fixed lint error
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.