[Serve] Remove the warning for async handles in 2.0 #27346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: simon-mo <[email protected]>
sihanwang41
approved these changes
Aug 2, 2022
simon-mo
added a commit
to simon-mo/ray
that referenced
this pull request
Aug 7, 2022
Signed-off-by: simon-mo <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
Signed-off-by: simon-mo <[email protected]> Signed-off-by: Scott Graham <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
Signed-off-by: simon-mo <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: simon-mo <[email protected]> Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR removes the warning about using sync handles in async context (common) and using async handle in sync context (rare). In Serve 2.0, we are helping user to inject the handles via .bind API. However, the only handles we are injecting right now is SyncHandle due to technical limitation. Therefore we want to remove this non-actionable warnings.
Related issue number
Closes #27266
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.