[Hotfix] Fix the failure of C++ tests #27249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 久龙 <[email protected]>
|
@architkulkarni can you take a look at the runtime env related code? |
Signed-off-by: 久龙 <[email protected]>
9699890
to
87c6b47
Compare
|
@SongGuyang is it ready to merge? also can you help me understand the impact of release rc0 without this fix? |
|
@scv119 The test has passed in my mac after this PR. But I can't varify it in CI now. I think we can merge it and release rc0 first. But If we don't pick this PR, the basic cpp tests will fail after the users install the rc wheel. |
architkulkarni
approved these changes
Jul 29, 2022
SongGuyang
added a commit
to alipay/ant-ray
that referenced
this pull request
Jul 29, 2022
Signed-off-by: 久龙 <[email protected]>
scv119
pushed a commit
that referenced
this pull request
Jul 29, 2022
Signed-off-by: 久龙 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: 久龙 <[email protected]> Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 久龙 [email protected]
Fix the issue #27237