[Serve] Disable macOS tests #27218
Merged
[Serve] Disable macOS tests #27218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: simon-mo <[email protected]>
scv119
approved these changes
Jul 28, 2022
sihanwang41
approved these changes
Jul 28, 2022
|
@scv119 let me know if you are interested to get this in 2.0 to make release builds maybe slightly faster? |
What about that 1 issue it may find? Do we need to run it but with less frequency (once per week or something like that). |
|
It won't impact production and stake is low. |
franklsf95
pushed a commit
to franklsf95/ray
that referenced
this pull request
Aug 2, 2022
Signed-off-by: Frank Luan <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
Signed-off-by: Scott Graham <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
Chong-Li
pushed a commit
to alipay/ant-ray
that referenced
this pull request
Aug 16, 2022
Signed-off-by: Chong-Li <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: simon-mo [email protected]
Why are these changes needed?
Serve's macOS didn't do much to help identity breakages and the main deployment target is always based on linux. In the past two year we found close to zero issue related to macOS specific bug. Our mac builds are slow and cost; therefore, disabling them for now..
Related issue number
Overall this should reduce the CI time of the ":mac: :apple: Ray Core, Dashboard and Serve" by about 30min
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.