Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Cleanup workflow docs #27197

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

suquark
Copy link
Member

@suquark suquark commented Jul 28, 2022

Signed-off-by: Siyuan Zhuang [email protected]

Why are these changes needed?

  • Unify the component name - "Ray Workflow" instead of "workflow", "workflows", "Ray workflow", "Ray workflows", "Ray Workflows"
  • Remove remaining part about virtual actors

Related issue number

Closes #26971

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Siyuan Zhuang <[email protected]>
@suquark suquark changed the title [Workflow] Update workflow docs [Workflow] Cleanup workflow docs Jul 28, 2022
Signed-off-by: Siyuan Zhuang <[email protected]>
@fishbone
Copy link
Contributor

LGTM. Please create a ray 2.0 cherry-pick pr (similar to #27114)

@suquark suquark mentioned this pull request Jul 28, 2022
7 tasks
@fishbone fishbone added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jul 29, 2022
@suquark
Copy link
Member Author

suquark commented Jul 29, 2022

The CI failure is unlikely related to the doc cleanup. I'll merge it.

@suquark suquark merged commit 1bcd3e4 into ray-project:master Jul 29, 2022
@suquark suquark deleted the update_workflow_doc branch July 29, 2022 20:03
@zhe-thoughts zhe-thoughts added the docs An issue or change related to documentation label Jul 30, 2022
@zhe-thoughts
Copy link
Collaborator

hi folks, great work here :) quick note that let's also not forget "ticket hygiene" of applying / removing labels as appropriate

franklsf95 pushed a commit to franklsf95/ray that referenced this pull request Aug 2, 2022
* cleanup workflow docs

Signed-off-by: Siyuan Zhuang <[email protected]>
Signed-off-by: Frank Luan <[email protected]>
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
* cleanup workflow docs

Signed-off-by: Siyuan Zhuang <[email protected]>
Signed-off-by: Scott Graham <[email protected]>
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
* cleanup workflow docs

Signed-off-by: Siyuan Zhuang <[email protected]>
Chong-Li pushed a commit to alipay/ant-ray that referenced this pull request Aug 16, 2022
* cleanup workflow docs

Signed-off-by: Siyuan Zhuang <[email protected]>
Signed-off-by: Chong-Li <[email protected]>
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
* cleanup workflow docs

Signed-off-by: Siyuan Zhuang <[email protected]>
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. docs An issue or change related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Workflow][Docs] Update Workflow Docs from Workflows to Workflow (removing s)
3 participants