Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Remove release tests for checkpoint_path #27194

Merged

Conversation

simon-mo
Copy link
Contributor

This test should be removed when we officially removed the
checkpoint_path but it was missed. checkpoint_path is no longer
exposed API and we encourage user to use K8s operator and GCS FT.

Signed-off-by: simon-mo [email protected]

Why are these changes needed?

Related issue number

Closes #27189

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

This test should be removed when we officially removed the
checkpoint_path but it was missed. checkpoint_path is no longer
exposed API and we encourage user to use K8s operator and GCS FT.

Signed-off-by: simon-mo <[email protected]>
@simon-mo simon-mo marked this pull request as ready for review July 28, 2022 17:15
@simon-mo simon-mo added release-blocker P0 Issue that blocks the release v2.0.0-pick labels Jul 28, 2022
@simon-mo
Copy link
Contributor Author

@scv119 This PR just removes the test, it should be harmless to merge and cherry pick anytime.

Copy link
Contributor

@sihanwang41 sihanwang41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this one! Thank you!

@ericl ericl removed the v2.0.0-pick label Jul 28, 2022
@ericl
Copy link
Contributor

ericl commented Jul 28, 2022

This PR doesn't seem critical for 2.0--- let's not pick it.

@simon-mo
Copy link
Contributor Author

@ericl This is a release test fix, please see the linked issue #27189

@simon-mo simon-mo merged commit 8beb887 into ray-project:master Jul 28, 2022
simon-mo added a commit to simon-mo/ray that referenced this pull request Jul 28, 2022
scv119 pushed a commit that referenced this pull request Jul 28, 2022
franklsf95 pushed a commit to franklsf95/ray that referenced this pull request Aug 2, 2022
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
Chong-Li pushed a commit to alipay/ant-ray that referenced this pull request Aug 16, 2022
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0][nightly] 8. serve_serve_cluster_fault_tolerance failed
5 participants