[ci][kuberay] Always cleanup KinD cluster #27073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cleaning up after the k8s operator tests, we should always delete the k8s cluster even if something went wrong (in fact, it's not clear we even need to clean up the resources within the cluster. Signed-off-by: Alex Wu <[email protected]>
DmitriGekhtman
approved these changes
Jul 27, 2022
|
Operator test passes, other failures are unrelated. Merging. |
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
When cleaning up after the k8s operator tests, we should always delete the k8s cluster even if something went wrong (in fact, it's not clear we even need to clean up the resources within the cluster. Signed-off-by: Alex Wu <[email protected]> Signed-off-by: Rohan138 <[email protected]>
franklsf95
pushed a commit
to franklsf95/ray
that referenced
this pull request
Aug 2, 2022
When cleaning up after the k8s operator tests, we should always delete the k8s cluster even if something went wrong (in fact, it's not clear we even need to clean up the resources within the cluster. Signed-off-by: Alex Wu <[email protected]> Signed-off-by: Frank Luan <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
When cleaning up after the k8s operator tests, we should always delete the k8s cluster even if something went wrong (in fact, it's not clear we even need to clean up the resources within the cluster. Signed-off-by: Alex Wu <[email protected]> Signed-off-by: Scott Graham <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
When cleaning up after the k8s operator tests, we should always delete the k8s cluster even if something went wrong (in fact, it's not clear we even need to clean up the resources within the cluster. Signed-off-by: Alex Wu <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
When cleaning up after the k8s operator tests, we should always delete the k8s cluster even if something went wrong (in fact, it's not clear we even need to clean up the resources within the cluster. Signed-off-by: Alex Wu <[email protected]> Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cleaning up after the k8s operator tests, we should always delete the k8s cluster even if something went wrong (in fact, it's not clear we even need to clean up the resources within the cluster.
Signed-off-by: Alex Wu [email protected]
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.