[State Observability] Add warnings for data truncation + order columns as it is defined in StateSchema
#27018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickyyx
approved these changes
Jul 26, 2022
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
…s as it is defined in `StateSchema` (ray-project#27018) # Why are these changes needed? This PR does 3 things Add warnings for data truncation (which is a follow-up) Improve some of confusing warning messages order columns as it is defined in StateSchema (so that we can customize the column order for better usability). I did this only for list because i thought it wasn't that important for summary, but I might be wrong Signed-off-by: Rohan138 <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…s as it is defined in `StateSchema` (ray-project#27018) # Why are these changes needed? This PR does 3 things Add warnings for data truncation (which is a follow-up) Improve some of confusing warning messages order columns as it is defined in StateSchema (so that we can customize the column order for better usability). I did this only for list because i thought it wasn't that important for summary, but I might be wrong Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR does 3 things
StateSchema(so that we can customize the column order for better usability). I did this only for list because i thought it wasn't that important for summary, but I might be wrongRelated issue number
Checks
scripts/format.shto lint the changes in this PR.