[RLlib] Try to checkpoint a durable policy name #27016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20bd29f
to
3d834b2
Compare
| @@ -102,21 +102,42 @@ def __eq__(self, other: "PolicySpec"): | |||
| ) | |||
|
|
|||
| def serialize(self) -> Dict: | |||
| from ray.rllib.algorithms.registry import get_policy_class_name | |||
There was a problem hiding this comment.
Add the import to the top of the file
There was a problem hiding this comment.
I can't 😭
circular dependency somehow ...
kouroshHakha
approved these changes
Jul 26, 2022
| if name not in POLICIES: | ||
| return None | ||
|
|
||
| path = POLICIES[name] |
There was a problem hiding this comment.
What if the name does not exist? e.g. custom policy?
There was a problem hiding this comment.
return None above.
in this case, we will checkpoint the raw policy class for the user and print a warning message.
I feel like if you want to use custom policy, then you'd better handle compatibility yourself?
added 2 commits
July 26, 2022 20:36
Rohan138
pushed a commit
to Rohan138/ray
that referenced
this pull request
Jul 28, 2022
Signed-off-by: Rohan138 <[email protected]>
franklsf95
pushed a commit
to franklsf95/ray
that referenced
this pull request
Aug 2, 2022
Signed-off-by: Frank Luan <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
Signed-off-by: Scott Graham <[email protected]>
gramhagen
pushed a commit
to gramhagen/ray
that referenced
this pull request
Aug 15, 2022
Chong-Li
pushed a commit
to alipay/ant-ray
that referenced
this pull request
Aug 16, 2022
Signed-off-by: Chong-Li <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
instead of the raw policy class.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.