Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Make sure no side effects during workflow resuming #26918

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

suquark
Copy link
Member

@suquark suquark commented Jul 23, 2022

Signed-off-by: Siyuan Zhuang [email protected]

Why are these changes needed?

A very simple PR that makes sure #19481 will not happen in the future.

Related issue number

Closes #19481

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@suquark
Copy link
Member Author

suquark commented Jul 23, 2022

CI failure seems not related.

@suquark suquark merged commit 1fa8ddb into ray-project:master Jul 23, 2022
@suquark suquark deleted the workflow_resume_side_effects branch July 23, 2022 18:04
yaxife pushed a commit to alipay/ant-ray that referenced this pull request Jul 26, 2022
klwuibm pushed a commit to yuanchi2807/ray that referenced this pull request Jul 27, 2022
Catch-Bull pushed a commit to alipay/ant-ray that referenced this pull request Jul 27, 2022
Rohan138 pushed a commit to Rohan138/ray that referenced this pull request Jul 28, 2022
franklsf95 pushed a commit to franklsf95/ray that referenced this pull request Aug 2, 2022
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Workflow] Workflow.resume of a nonexistent workflow has side effects
2 participants