Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][State Observability] Fix is_alive column with wrong column type that breaks filtering #26739

Merged
merged 3 commits into from
Jul 20, 2022

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Jul 19, 2022

Why are these changes needed?

is_alive column of the WorkerState has wrong column type that breaks filtering on is_alive

Related issue number

Closes #26613

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • CLI tests

@rickyyx rickyyx added this to the Ray State Observability milestone Jul 19, 2022
@rickyyx rickyyx requested a review from rkooo567 July 19, 2022 20:59
@rickyyx rickyyx marked this pull request as ready for review July 19, 2022 21:00
Signed-off-by: rickyyx <[email protected]>
Signed-off-by: rickyyx <[email protected]>
@rkooo567 rkooo567 merged commit 6ee37d4 into ray-project:master Jul 20, 2022
shrekris-anyscale pushed a commit to shrekris-anyscale/ray that referenced this pull request Jul 22, 2022
…e that breaks filtering (ray-project#26739)

is_alive column of the WorkerState has wrong column type that breaks filtering on is_alive

Signed-off-by: Shreyas Krishnaswamy <[email protected]>
yaxife pushed a commit to alipay/ant-ray that referenced this pull request Jul 26, 2022
…e that breaks filtering (ray-project#26739)

is_alive column of the WorkerState has wrong column type that breaks filtering on is_alive

Signed-off-by: nanqi.yxf <[email protected]>
klwuibm pushed a commit to yuanchi2807/ray that referenced this pull request Jul 27, 2022
…e that breaks filtering (ray-project#26739)

is_alive column of the WorkerState has wrong column type that breaks filtering on is_alive

Signed-off-by: klwuibm <[email protected]>
Catch-Bull pushed a commit to alipay/ant-ray that referenced this pull request Jul 27, 2022
…e that breaks filtering (ray-project#26739)

is_alive column of the WorkerState has wrong column type that breaks filtering on is_alive

Signed-off-by: Catch-Bull <[email protected]>
Rohan138 pushed a commit to Rohan138/ray that referenced this pull request Jul 28, 2022
…e that breaks filtering (ray-project#26739)

is_alive column of the WorkerState has wrong column type that breaks filtering on is_alive


Signed-off-by: Rohan138 <[email protected]>
franklsf95 pushed a commit to franklsf95/ray that referenced this pull request Aug 2, 2022
…e that breaks filtering (ray-project#26739)

is_alive column of the WorkerState has wrong column type that breaks filtering on is_alive


Signed-off-by: Frank Luan <[email protected]>
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
…e that breaks filtering (ray-project#26739)

is_alive column of the WorkerState has wrong column type that breaks filtering on is_alive


Signed-off-by: Scott Graham <[email protected]>
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
…e that breaks filtering (ray-project#26739)

is_alive column of the WorkerState has wrong column type that breaks filtering on is_alive
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
…e that breaks filtering (ray-project#26739)

is_alive column of the WorkerState has wrong column type that breaks filtering on is_alive

Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core][State Observability] Filtering with worker is alive does not work
2 participants