Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve][AIR] Fix pandas_read_json compatibility issue #26494

Merged
merged 2 commits into from
Jul 14, 2022

Conversation

simon-mo
Copy link
Contributor

@simon-mo simon-mo commented Jul 13, 2022

Why are these changes needed?

The following snippet

pd.read_json(b'[{"a": 1}]')

works in pandas 1.3.5; but fails in 1.4.2 and higher because pandas no longer accept bytes anymore.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo simon-mo marked this pull request as ready for review July 13, 2022 01:27
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we upgrade the pandas version used in CI?

@simon-mo
Copy link
Contributor Author

it's already

pandas>=1.0.5; python_version < '3.7'
pandas>=1.3.0; python_version >= '3.7'

I think the issue is that most of our CI run in 3.6 still because 3.6 is the minimal version Ray support.

@simon-mo
Copy link
Contributor Author

This probably means Pandas stop releasing for 3.6

@simon-mo simon-mo merged commit ef1d5c9 into ray-project:master Jul 14, 2022
xwjiang2010 pushed a commit to xwjiang2010/ray that referenced this pull request Jul 19, 2022
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants