Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune/CI] Fix BOHB notebook example #26473

Merged
merged 4 commits into from
Jul 13, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jul 12, 2022

Signed-off-by: Antoni Baum [email protected]

Why are these changes needed?

Fixes the BOHB notebook example as found in #26410

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010
Copy link
Contributor

What was the issue with this example?

@Yard1
Copy link
Member Author

Yard1 commented Jul 12, 2022

ConfigSpace being passed into tune.run instead of into the searcher&scheduler, bad metric name, missing steps from ConfigSpace

@krfricke krfricke merged commit 67a7ffa into ray-project:master Jul 13, 2022
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Fixes the BOHB notebook example as found in ray-project#26410

Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants