Enable usage stats collection for ray.init iff nightly wheels #26461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericl
reviewed
Jul 13, 2022
| elif usage_stats_enabledness is UsageStatsEnabledness.ENABLED_BY_DEFAULT: | ||
|
|
||
| if cli_logger.interactive: | ||
| if not cli: |
There was a problem hiding this comment.
It seems this path is only hit for nightly wheels. Consider renaming the cli flag and also the message to is_nightly / ...ENABLED_BY_DEFAULT_FOR_NIGHTLY_MESSAGE for clarity.
There was a problem hiding this comment.
It's more of cli vs ray.init rather than nightly vs non-nightly. Nightly cli and non-nightly cli are the same.
ericl
reviewed
Jul 13, 2022
ericl
reviewed
Jul 13, 2022
ericl
approved these changes
Jul 13, 2022
DmitriGekhtman
approved these changes
Jul 13, 2022
rkooo567
approved these changes
Jul 13, 2022
wuisawesome
approved these changes
Jul 13, 2022
xwjiang2010
pushed a commit
to xwjiang2010/ray
that referenced
this pull request
Jul 19, 2022
…oject#26461) For nightly wheels, we want to collect usage stats for local clusters started via ray.init() as well. Signed-off-by: Xiaowei Jiang <[email protected]>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…oject#26461) For nightly wheels, we want to collect usage stats for local clusters started via ray.init() as well. Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
For nightly wheels, we want to collect usage stats for local clusters started via
ray.init()as well.Related issue number
Checks
scripts/format.shto lint the changes in this PR.