-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix redis dependency #26459
Fix redis dependency #26459
Conversation
You should be able to build that docker image locally and see if this does the right thing (running the commend from the CI manually from your laptop) |
Thanks for the tip. Let me try it out -- it might not have worked out last time I tried it on a Mac. |
Ok, I figured out how to work the build command locally. Now just need to fidget the formatting some more with some local experiments. |
It seems I had some spare spaces. |
Verified that it works in https://buildkite.com/ray-project/ray-builders-pr/builds/37972#0181f40c-b88f-468e-ae1d-0716246005b4 |
Thank you for the stamps. Will pull nightly to re-confirm once it's built in ~1 hour. |
Fix the specification of the Redis dependency for the Ray image. Signed-off-by: Edward Oakes <[email protected]>
Fix the specification of the Redis dependency for the Ray image. Signed-off-by: Nikita Vemuri <[email protected]>
Fix the specification of the Redis dependency for the Ray image. Signed-off-by: Avnish <[email protected]>
Fix the specification of the Redis dependency for the Ray image. Signed-off-by: klwuibm <[email protected]>
Fix the specification of the Redis dependency for the Ray image. Signed-off-by: Frank Luan <[email protected]>
Fix the specification of the Redis dependency for the Ray image. Signed-off-by: Scott Graham <[email protected]>
Fix the specification of the Redis dependency for the Ray image.
Fix the specification of the Redis dependency for the Ray image. Signed-off-by: Stefan van der Kleij <[email protected]>
Why are these changes needed?
Something seems to have gone wrong in #26446.
Redis was not available in the built image.
This PR makes an attempt to fix the issue.
I'm not sure how to test this PR.
I will try to verify the PR manually by poking around the CI environment.
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.