Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redis dependency #26459

Merged

Conversation

DmitriGekhtman
Copy link
Contributor

Why are these changes needed?

Something seems to have gone wrong in #26446.
Redis was not available in the built image.
This PR makes an attempt to fix the issue.

I'm not sure how to test this PR.
I will try to verify the PR manually by poking around the CI environment.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@DmitriGekhtman DmitriGekhtman changed the title Try adding quotes. Fix redis dependency Jul 12, 2022
@pcmoritz
Copy link
Contributor

You should be able to build that docker image locally and see if this does the right thing (running the commend from the CI manually from your laptop)

@DmitriGekhtman
Copy link
Contributor Author

You should be able to build that docker image locally and see if this does the right thing (running the commend from the CI manually from your laptop)

Thanks for the tip. Let me try it out -- it might not have worked out last time I tried it on a Mac.

@DmitriGekhtman
Copy link
Contributor Author

Ok, I figured out how to work the build command locally. Now just need to fidget the formatting some more with some local experiments.

@DmitriGekhtman
Copy link
Contributor Author

It seems I had some spare spaces.
I've opened a separate PR (not for merging) to verify https://github.com/ray-project/ray/pull/26480/files.

@DmitriGekhtman
Copy link
Contributor Author

@DmitriGekhtman
Copy link
Contributor Author

Thank you for the stamps. Will pull nightly to re-confirm once it's built in ~1 hour.

@DmitriGekhtman DmitriGekhtman merged commit 0c1b6df into ray-project:master Jul 12, 2022
edoakes pushed a commit to edoakes/ray that referenced this pull request Jul 14, 2022
Fix the specification of the Redis dependency for the Ray image.

Signed-off-by: Edward Oakes <[email protected]>
nikitavemuri pushed a commit to nikitavemuri/ray that referenced this pull request Jul 15, 2022
Fix the specification of the Redis dependency for the Ray image.

Signed-off-by: Nikita Vemuri <[email protected]>
avnishn pushed a commit to smorad/ray that referenced this pull request Jul 20, 2022
Fix the specification of the Redis dependency for the Ray image.

Signed-off-by: Avnish <[email protected]>
klwuibm pushed a commit to yuanchi2807/ray that referenced this pull request Jul 27, 2022
Fix the specification of the Redis dependency for the Ray image.

Signed-off-by: klwuibm <[email protected]>
franklsf95 pushed a commit to franklsf95/ray that referenced this pull request Aug 2, 2022
Fix the specification of the Redis dependency for the Ray image.

Signed-off-by: Frank Luan <[email protected]>
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
Fix the specification of the Redis dependency for the Ray image.

Signed-off-by: Scott Graham <[email protected]>
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
Fix the specification of the Redis dependency for the Ray image.
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Fix the specification of the Redis dependency for the Ray image.

Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants