Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix nightly horovod test #26447

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jul 11, 2022

Why are these changes needed?

Related issue number

Closes #26440

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Yard1 Yard1 requested a review from xwjiang2010 July 11, 2022 18:36
@Yard1 Yard1 marked this pull request as ready for review July 11, 2022 20:01
@xwjiang2010
Copy link
Contributor

@xwjiang2010
Copy link
Contributor

test is hanging. Could that have something to do with the fact that Trainer also reserves one CPU? So 8 CPU won't cut it?

@Yard1
Copy link
Member Author

Yard1 commented Jul 12, 2022

Yes that is correct! Will need to reduce the number of workers.

@krfricke krfricke merged commit a8fb194 into ray-project:master Jul 13, 2022
@Yard1 Yard1 deleted the fix_horovod_nightly branch July 13, 2022 15:52
truelegion47 pushed a commit to truelegion47/ray that referenced this pull request Jul 14, 2022
Removes usage of deprecated Train APIs and uses Ray AIR HorovodTrainer instead.

Signed-off-by: Your Name <[email protected]>
edoakes pushed a commit to edoakes/ray that referenced this pull request Jul 14, 2022
Removes usage of deprecated Train APIs and uses Ray AIR HorovodTrainer instead.

Signed-off-by: Edward Oakes <[email protected]>
nikitavemuri pushed a commit to nikitavemuri/ray that referenced this pull request Jul 15, 2022
Removes usage of deprecated Train APIs and uses Ray AIR HorovodTrainer instead.

Signed-off-by: Nikita Vemuri <[email protected]>
truelegion47 pushed a commit to truelegion47/ray that referenced this pull request Jul 16, 2022
Removes usage of deprecated Train APIs and uses Ray AIR HorovodTrainer instead.

Signed-off-by: Your Name <[email protected]>
avnishn pushed a commit to smorad/ray that referenced this pull request Jul 20, 2022
Removes usage of deprecated Train APIs and uses Ray AIR HorovodTrainer instead.

Signed-off-by: Avnish <[email protected]>
klwuibm pushed a commit to yuanchi2807/ray that referenced this pull request Jul 27, 2022
Removes usage of deprecated Train APIs and uses Ray AIR HorovodTrainer instead.

Signed-off-by: klwuibm <[email protected]>
franklsf95 pushed a commit to franklsf95/ray that referenced this pull request Aug 2, 2022
Removes usage of deprecated Train APIs and uses Ray AIR HorovodTrainer instead.

Signed-off-by: Frank Luan <[email protected]>
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
Removes usage of deprecated Train APIs and uses Ray AIR HorovodTrainer instead.

Signed-off-by: Scott Graham <[email protected]>
gramhagen pushed a commit to gramhagen/ray that referenced this pull request Aug 15, 2022
Removes usage of deprecated Train APIs and uses Ray AIR HorovodTrainer instead.
Stefan-1313 pushed a commit to Stefan-1313/ray_mod that referenced this pull request Aug 18, 2022
Removes usage of deprecated Train APIs and uses Ray AIR HorovodTrainer instead.

Signed-off-by: Stefan van der Kleij <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ml release] horovod train test is failing
3 participants