Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Revert "[Dashboard][Serve] Move Serve related endpoints to dashboard agent""" #26348

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jul 7, 2022

Reverts #26336

@xwjiang2010
Copy link
Contributor

Lots of tests failing in post submit. Notably

ModuleNotFoundError: No module named 'ray.air'
ModuleNotFoundError: No module named 'ray.tests'

Not sure how it may be caused by this PR tho...

@Yard1 Yard1 closed this Jul 7, 2022
@Yard1 Yard1 deleted the revert-26336-revert-26333-revert-26107-bruce/nightlyAgent3 branch July 7, 2022 06:25
@Yard1
Copy link
Member Author

Yard1 commented Jul 7, 2022

Closing as it didn't fix it. https://buildkite.com/ray-project/ray-builders-branch/builds/8511

@SongGuyang
Copy link
Contributor

Do you know the root cause of the tests failing?

@krfricke
Copy link
Contributor

krfricke commented Jul 7, 2022

The problem is that one of the dependencies requires: ray<1.13.0,>=1.8.0

I'll find out which one that is...

@krfricke
Copy link
Contributor

krfricke commented Jul 7, 2022

It's raydp-nightly. I'll prepare a PR

@krfricke
Copy link
Contributor

krfricke commented Jul 7, 2022

Hopefully this fixes it: #26356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants