Revert "[Observability] Fix --follow lost connection when it is used for > 30 seconds" #26162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rkooo567 |
jjyao
approved these changes
Jun 28, 2022
|
Oops.. hope I could merge this #26156 (review) before it was reverted.. 😢 I will recreate a PR lol |
rkooo567
added a commit
to rkooo567/ray
that referenced
this pull request
Jun 28, 2022
…is used for > 30 seconds (ray-project#26080)" (ray-project#26162)" This reverts commit 3017128.
rkooo567
added a commit
that referenced
this pull request
Jun 28, 2022
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Jul 14, 2022
…for > 30 seconds (ray-project#26080)" (ray-project#26162) This reverts commit 2d58bd5. Signed-off-by: Edward Oakes <[email protected]>
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Jul 14, 2022
…s used for > 30 seconds" ray-project#26162 (ray-project#26163) * Revert "Revert "[Observability] Fix --follow lost connection when it is used for > 30 seconds (ray-project#26080)" (ray-project#26162)" This reverts commit 3017128. Signed-off-by: Edward Oakes <[email protected]>
klwuibm
pushed a commit
to yuanchi2807/ray
that referenced
this pull request
Jul 27, 2022
…for > 30 seconds (ray-project#26080)" (ray-project#26162) This reverts commit 2d58bd5. Signed-off-by: klwuibm <[email protected]>
klwuibm
pushed a commit
to yuanchi2807/ray
that referenced
this pull request
Jul 27, 2022
…s used for > 30 seconds" ray-project#26162 (ray-project#26163) * Revert "Revert "[Observability] Fix --follow lost connection when it is used for > 30 seconds (ray-project#26080)" (ray-project#26162)" This reverts commit 3017128. Signed-off-by: klwuibm <[email protected]>
franklsf95
pushed a commit
to franklsf95/ray
that referenced
this pull request
Aug 2, 2022
…for > 30 seconds (ray-project#26080)" (ray-project#26162) This reverts commit 2d58bd5. Signed-off-by: Frank Luan <[email protected]>
franklsf95
pushed a commit
to franklsf95/ray
that referenced
this pull request
Aug 2, 2022
…s used for > 30 seconds" ray-project#26162 (ray-project#26163) * Revert "Revert "[Observability] Fix --follow lost connection when it is used for > 30 seconds (ray-project#26080)" (ray-project#26162)" This reverts commit 3017128. Signed-off-by: Frank Luan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #26080
Looks like it breaks windows:https://python/ray/tests:test_state_api_log