Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard][Serve] Move Serve related endpoints to dashboard agent #26107

Merged
merged 60 commits into from
Jul 6, 2022

Conversation

brucez-anyscale
Copy link
Contributor

@brucez-anyscale brucez-anyscale commented Jun 26, 2022

Why are these changes needed?

In Ray 2.0, we want to achieve api server HA.
Originally serve endpoints are in head node.
This pr moves serve endpoints to dashboard agents, so they will be HA due to multiple replica of dashboard agent.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@brucez-anyscale brucez-anyscale changed the title Bruce/nightly agent3 Ray: Move serve deployment related endpoints to dashboard agent for HA Jun 26, 2022
@simon-mo
Copy link
Contributor

This requires more work regarding minimal installation.

@brucez-anyscale
Copy link
Contributor Author

This requires more work regarding minimal installation.

@rkooo567 Do you think if we can remove if not self.minimal: condition in agent.py and always starts the http server?

Copy link
Contributor

@shrekris-anyscale shrekris-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this change!

@shrekris-anyscale shrekris-anyscale changed the title [Dasshboard][Serve] Move Serve related endpoints to dashboard agent [Dashboard][Serve] Move Serve related endpoints to dashboard agent Jul 5, 2022
@fishbone
Copy link
Contributor

fishbone commented Jul 6, 2022

default install failed. maybe you need to tune your tests a little bit.

@rkooo567
Copy link
Contributor

rkooo567 commented Jul 6, 2022

I will leave merge to @iycheng

@fishbone fishbone merged commit 84166cc into ray-project:master Jul 6, 2022
fishbone added a commit that referenced this pull request Jul 6, 2022
fishbone added a commit that referenced this pull request Jul 6, 2022
brucez-anyscale added a commit that referenced this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants